Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mongodb-core patch level #198

Merged
merged 1 commit into from
Jun 16, 2015
Merged

Update mongodb-core patch level #198

merged 1 commit into from
Jun 16, 2015

Conversation

shakefu
Copy link
Contributor

@shakefu shakefu commented Jun 16, 2015

The latest ([email protected]) fixes errors in mongodb-core (@1.1.9) where the bson C++ extension fails to build and then complains loudly about it every time the module is instantiated.

Gets rid of this:

{ [Error: Cannot find module '../build/Release/bson'] code: 'MODULE_NOT_FOUND' }
js-bson: Failed to load c++ bson extension, using pure JS version

@sorribas
Copy link
Collaborator

Thanks very much. Travis failed but I tested it on my machine and it seems to work. I'll look into the travis config as there seems to be somthing wrong with it.

sorribas added a commit that referenced this pull request Jun 16, 2015
Update mongodb-core patch level
@sorribas sorribas merged commit 939907e into mongo-js:master Jun 16, 2015
@sorribas
Copy link
Collaborator

Actually, I made a mistake, I ran the tests before running npm install (silly me). So the error that showed up in travis is actually happening. I'll look into it.

@mderazon mderazon mentioned this pull request Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants