Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use amount from monero-rs #68

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Use amount from monero-rs #68

merged 3 commits into from
Jul 19, 2022

Conversation

LeoNero
Copy link
Member

@LeoNero LeoNero commented Jul 13, 2022 •
edited
Loading

Closes #46

@LeoNero LeoNero changed the title wip wip: use amount from monero-rs Jul 13, 2022
@LeoNero LeoNero mentioned this pull request Jul 14, 2022
Merged
@LeoNero
Copy link
Member Author

LeoNero commented Jul 14, 2022

This is working, gonna just wait for the PR on monero-rs to be merged, and then I'll fix the commits and Cargo.toml :)

@LeoNero LeoNero marked this pull request as ready for review July 19, 2022 19:28
@LeoNero
Copy link
Member Author

LeoNero commented Jul 19, 2022

@TheCharlatan I cannot assign you as a reviewer.

@LeoNero LeoNero changed the title wip: use amount from monero-rs Use amount from monero-rs Jul 19, 2022
TheCharlatan
TheCharlatan approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, I looked through everything again and could not find a missed conversion.

@TheCharlatan TheCharlatan merged commit 9bdf668 into monero-rs:master Jul 19, 2022
refring pushed a commit to refring/monero-rpc-rs that referenced this pull request Oct 16, 2022
@LeoNero
Use amount from monero-rs (monero-rs#68)
ccbcb49 
* feat(models): use `Amount` from `monero-rs` instead of `u64` where possible

* fix(lib): fix `below_amount` argument in `sweep_all` call

* docs(CHANGELOG): update CHANGELOG to reflect most recent changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheCharlatan TheCharlatan TheCharlatan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use new Amount serde from monero-rs
2 participants
@LeoNero @TheCharlatan