Allow using upstream creds from scan job #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
reviewed
Nov 24, 2022
policy/scan/local_scanner.go
Outdated
| spaceMrn := s.spaceMrn | ||
| jobCredentials := job.Inventory.Spec.UpstreamCredentals | ||
|
|
||
| if s.useJobCredentials && jobCredentials != nil { |
There was a problem hiding this comment.
semantically we could call it:
useJobCredentials- in this case I would expect that all jobs need their own credentials, no fall back to default credentialsallowJobCredentials- here job credentials are optional
Depending on what you want to achieve, we need to decide for the wording and then implement it accordinly
There was a problem hiding this comment.
Good point. I went with the latter (AllowJobCredentials) as I feel that's a bit more flexible
There was a problem hiding this comment.
Perfect, makes a lot of sense. We can restrict that further going forward if we need to
…can. Signed-off-by: Preslav <[email protected]>
Signed-off-by: Preslav <[email protected]>
preslavgerchev
force-pushed
the
preslav/upstream-creds
branch
from
e925625
to
2fb1267
Compare
chris-rock
reviewed
Nov 25, 2022
…o get the correct header. Signed-off-by: Preslav <[email protected]>
preslavgerchev
force-pushed
the
preslav/upstream-creds
branch
from
9a91f8a
to
e04dd9e
Compare
chris-rock
reviewed
Nov 28, 2022
…he original map. Signed-off-by: Preslav <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the scanner to use credentials from an inventory job. Only works if that's enabled via
EnableJobCredentials