Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ policy last applied field #1472

Merged
merged 3 commits into from
Nov 15, 2024
Merged

✨ policy last applied field #1472

merged 3 commits into from
Nov 15, 2024

Conversation

slntopp
Copy link
Member

@slntopp slntopp commented Nov 5, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Test Results

  1 files  ±0   25 suites  ±0   20s ⏱️ +3s
438 tests ±0  437 ✅ ±0  1 💤 ±0  0 ❌ ±0 
439 runs  ±0  438 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 67342cc. ± Comparison against base commit 965688e.

♻️ This comment has been updated with latest results.

@@ -114,6 +116,8 @@ message Policy {
string graph_content_checksum = 38;
string local_execution_checksum = 39;
string graph_execution_checksum = 40;
// timestamp when the policy was last applied
int64 last_applied = 48;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this one makes sense. I would only expect this information in PolicyRef. What's the thought for how this one is used?

@slntopp slntopp requested a review from jaym November 6, 2024 17:16
@slntopp slntopp closed this Nov 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
@slntopp slntopp reopened this Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (53)
admins
ansible
apiserver
automount
Bitcoin
BUSL
cafile
CHACHA
cnquery
cnspec
containerd
crt
daemonset
debian
Dockerfiles
emojis
ESXi
filesystems
freevxfs
gcp
github
gitlab
GOBIN
google
hfs
iex
inet
INSTANCEID
kube
kubeconfig
kubelet
kubernetes
mondoo
mondoohq
mql
mrn
mypolicy
oci
opcua
protobuf
protos
replicaset
rockylinux
SNAPSHOTID
statefulset
terraform
tunables
uid
vcd
VOLUMEID
vsphere
websites
winrm
To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:mondoohq/cnspec.git repository
on the mik/policy/last-applied-field branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' |
perl - 'https://github.com/mondoohq/cnspec/actions/runs/11722867152/attempts/1'
Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (17) from .github/actions/spelling/expect.txt and unrecognized words (53)

Dictionary Entries Covers Uniquely
cspell:k8s/dict/k8s.txt 153 11 9
cspell:php/dict/php.txt 1689 5 2
cspell:node/dict/node.txt 891 4
cspell:django/dict/django.txt 393 3 1
cspell:golang/dict/go.txt 2099 3 1

Consider adding them (in .github/workflows/spell-check.yaml) in jobs:/spelling: for uses: check-spelling/[email protected] in its with:

      with:
        extra_dictionaries: |
          cspell:k8s/dict/k8s.txt
          cspell:php/dict/php.txt
          cspell:node/dict/node.txt
          cspell:django/dict/django.txt
          cspell:golang/dict/go.txt

To stop checking additional dictionaries, add (in .github/workflows/spell-check.yaml) for uses: check-spelling/[email protected] in its with:

check_extra_dictionaries: ''
Errors (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ extra-dictionary-not-found 1

See ❌ Event descriptions for more information.

If the flagged items are false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@github-actions github-actions bot unlocked this conversation Nov 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
@slntopp slntopp force-pushed the mik/policy/last-applied-field branch from 67342cc to 9a31a33 Compare November 14, 2024 11:37
@slntopp slntopp merged commit e955b1f into main Nov 15, 2024
14 checks passed
@slntopp slntopp deleted the mik/policy/last-applied-field branch November 15, 2024 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants