Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Don't filter out scores of queries used for risk factors and not #1348

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

jaym
Copy link
Contributor

@jaym jaym commented Jul 1, 2024

If a query was used for a risk factor, its score was always being filtered out, regardless of if it might have been used outside of risk factors

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Test Results

  1 files  ±0   24 suites  ±0   18s ⏱️ ±0s
376 tests ±0  375 ✅ ±0  1 💤 ±0  0 ❌ ±0 
377 runs  ±0  376 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit ce83d41. ± Comparison against base commit 73ebd1e.

♻️ This comment has been updated with latest results.

If a query was used for a risk factor, its score was always being
filtered out, regardless of if it might have been used outside of risk
factors
@vjeffrey vjeffrey merged commit 4b001a6 into main Jul 2, 2024
13 checks passed
@vjeffrey vjeffrey deleted the jdm/rf-scores branch July 2, 2024 17:44
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants