Feat/map submission misc #1072
Merged
Feat/map submission misc #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ails Helpful for switching over error codes in C++.
This is used by ingame leaderboards for getting times for players in your lobby, wasn't supported on the new backend until now.
…o userIDs Just me being silly. Also, we may find requests using this param are have very long params, exceeding
Before, IntCsvQueryProperty was parsing this to BigInt at runtime, but TypeScript thought it was a string. The code just happened to work, even though types made no sense. I don't know if bigints or strings are fastest here, just sticking with strings since they're simplest.
I'm using this a lot in Pano and this name is so UGLY
…t forms Pressed this accidentally when adding private testers, accidentally submitted the entire thing. Not good!
GordiNoki
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bunch of map submission stuff I've had sitting around
Checks
nx run db:create-migration <name>and committed the migration if I've made DB schema changesfeat: Add foo,chore: Update bar, etc...fixuped into my original commits