Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord webhook notifications #1057

Merged
merged 3 commits into from
Oct 26, 2024
Merged

Discord webhook notifications #1057

merged 3 commits into from
Oct 26, 2024

Conversation

GordiNoki
Copy link
Member

Closes #607

Adds triggering discord webhooks for when map goes to public testing or was approved.

Tom, if you want me to move webhook service to separate module please comment here, I'm just not that sure about it.

Checks

  • !! DONT IGNORE ME !! I have ran nx run db:create-migration <name> and committed the migration if I've made DB schema changes
  • I have included/updated tests where applicable (see Testing)
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits

@GordiNoki GordiNoki force-pushed the feat/discord-webhook-notifactions branch from c32b406 to 20ddbd4 Compare October 19, 2024 21:27
@GordiNoki GordiNoki requested a review from tsa96 October 20, 2024 18:52
@GordiNoki GordiNoki force-pushed the feat/discord-webhook-notifactions branch from e2ca189 to f700f1a Compare October 20, 2024 20:04
@GordiNoki GordiNoki force-pushed the feat/discord-webhook-notifactions branch from f700f1a to 892ecdb Compare October 22, 2024 13:55
apps/backend/src/app/config/config.ts Outdated Show resolved Hide resolved
apps/backend/src/app/modules/maps/maps.service.ts Outdated Show resolved Hide resolved
apps/backend/src/app/modules/maps/maps.service.ts Outdated Show resolved Hide resolved
apps/backend-e2e/src/maps.e2e-spec.ts Outdated Show resolved Hide resolved
@GordiNoki GordiNoki force-pushed the feat/discord-webhook-notifactions branch 2 times, most recently from 5108e81 to 30c0d58 Compare October 24, 2024 06:21
Copy link
Member

@tsa96 tsa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry maybe I'm over-reviewing this a bit, stuck on a laptop as I have to stay downstairs to stop the puppy from chewing on the entire house.

apps/backend/src/app/modules/maps/maps.service.ts Outdated Show resolved Hide resolved
apps/backend/src/app/config/config.ts Outdated Show resolved Hide resolved
@GordiNoki GordiNoki force-pushed the feat/discord-webhook-notifactions branch from 30c0d58 to 0964e77 Compare October 26, 2024 20:42
@GordiNoki GordiNoki force-pushed the feat/discord-webhook-notifactions branch from 0964e77 to a2f7b45 Compare October 26, 2024 20:46
@tsa96 tsa96 merged commit 646b4d7 into main Oct 26, 2024
7 checks passed
@tsa96 tsa96 deleted the feat/discord-webhook-notifactions branch October 26, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post to webhook when new map is fully published
3 participants