-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discord webhook notifications #1057
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GordiNoki
force-pushed
the
feat/discord-webhook-notifactions
branch
from
October 19, 2024 21:27
c32b406
to
20ddbd4
Compare
GordiNoki
force-pushed
the
feat/discord-webhook-notifactions
branch
from
October 20, 2024 20:04
e2ca189
to
f700f1a
Compare
GordiNoki
force-pushed
the
feat/discord-webhook-notifactions
branch
from
October 22, 2024 13:55
f700f1a
to
892ecdb
Compare
tsa96
requested changes
Oct 23, 2024
GordiNoki
force-pushed
the
feat/discord-webhook-notifactions
branch
2 times, most recently
from
October 24, 2024 06:21
5108e81
to
30c0d58
Compare
tsa96
requested changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry maybe I'm over-reviewing this a bit, stuck on a laptop as I have to stay downstairs to stop the puppy from chewing on the entire house.
GordiNoki
force-pushed
the
feat/discord-webhook-notifactions
branch
from
October 26, 2024 20:42
30c0d58
to
0964e77
Compare
GordiNoki
force-pushed
the
feat/discord-webhook-notifactions
branch
from
October 26, 2024 20:46
0964e77
to
a2f7b45
Compare
tsa96
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #607
Adds triggering discord webhooks for when map goes to public testing or was approved.
Tom, if you want me to move webhook service to separate module please comment here, I'm just not that sure about it.
Checks
nx run db:create-migration <name>
and committed the migration if I've made DB schema changesfeat: Add foo
,chore: Update bar
, etc...fixup
ed into my original commits