Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use <lite-youtube-embed> for YouTube embeds #997

Open
tsa96 opened this issue Jul 8, 2024 · 0 comments
Open

Use <lite-youtube-embed> for YouTube embeds #997

tsa96 opened this issue Jul 8, 2024 · 0 comments
Labels
For: Frontend This is something to do for the front end (client folder) of the website. Priority: Low Something not very essential to the release, can be done in free time and bumped back if needed. Size: Small Something that may take a day at most to do. Type: Enhancement Something that builds on top of what already exists

Comments

@tsa96
Copy link
Member

tsa96 commented Jul 8, 2024 •
edited
Loading

Woe unto me, I'm making an issue just because of something I read on HackerNews on my phone 10 minutes ago.

YouTube embeds contain an absurd amount of bloat and are consistently bringing down lighthouse reports on our sites. Replacing with a less bloated version makes a lot of sense. Don't care about whatever nonsense Google claims about engagement metrics, fuck off.

Make sure to use the NPM package not a mirror, and probably best to wrap in an Angular component.
@tsa96 tsa96 added Type: Enhancement Something that builds on top of what already exists Size: Small Something that may take a day at most to do. Priority: Low Something not very essential to the release, can be done in free time and bumped back if needed. For: Frontend This is something to do for the front end (client folder) of the website. labels Jul 8, 2024
@tsa96 tsa96 mentioned this issue Jul 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
For: Frontend This is something to do for the front end (client folder) of the website. Priority: Low Something not very essential to the release, can be done in free time and bumped back if needed. Size: Small Something that may take a day at most to do. Type: Enhancement Something that builds on top of what already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tsa96