Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against loading moment-timezone twice #212

Closed
mattjohnsonpint opened this issue May 7, 2015 · 1 comment
Closed

Guard against loading moment-timezone twice #212

mattjohnsonpint opened this issue May 7, 2015 · 1 comment
Labels
enhancement

Comments

@mattjohnsonpint
Copy link
Contributor

A few reports from the wild, such as in #193 and on StackOverflow (and others) have shown that it's easy to accidentally load moment-timezone twice, which creates some problems.

Usually, it's a misunderstanding that moment-timezone-with-data already contains moment-timezone.

We should either guard against this, or at least prevent it from causing problems.
timrwood added a commit to timrwood/moment-timezone that referenced this issue May 12, 2015
@timrwood
Log an error if moment timezone was already loaded. moment#212
fe0ff9d
@timrwood timrwood mentioned this issue May 12, 2015
Merged
mattjohnsonpint added a commit that referenced this issue May 13, 2015
@mattjohnsonpint
Merge pull request #219 from timrwood/warn-when-loading-twice
3c82b06 
Log an error if moment timezone was already loaded. #212
@timrwood timrwood mentioned this issue May 30, 2015
Merged
@timrwood
Copy link
Member

timrwood commented Jun 1, 2015

This is released in 0.4.0.

@timrwood timrwood closed this as completed Jun 1, 2015
@mderazon mderazon mentioned this issue Jul 7, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timrwood @mattjohnsonpint