Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set _z in momentProperties #71

Merged
merged 1 commit into from
Apr 7, 2014
Merged

Conversation

ichernev
Copy link
Contributor

@ichernev ichernev commented Apr 3, 2014

This is related to moment/moment#1581 and moment/moment@aea66a8

@icambron
Copy link
Member

icambron commented Apr 3, 2014

@ichernev see Travis failure

@ichernev
Copy link
Contributor Author

ichernev commented Apr 3, 2014

I was wondering... This is going to run with latest moment that has it. Should we put an if there to check if the prop exists?

@icambron
Copy link
Member

icambron commented Apr 7, 2014

I think we should check the version of Moment and throw if it's too old.

icambron added a commit that referenced this pull request Apr 7, 2014
@icambron icambron merged commit 56ddb57 into moment:develop Apr 7, 2014
@ichernev ichernev deleted the fix-cloning-moments branch April 11, 2014 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants