moment-timezone performance issues

[louischatriot]

Hello,

Thanks for this library it really rocks. One issue I have with it though is performance. When using only moment and manipuilating dates, it is very fast. When adding timezone support it becomes much slower:

var m = moment(new Date());
m.add('days', 1);
// Takes ~0.2ms

m = moment(new Date()).tz("America/Los_Angeles");
m.add('days', 1);
// Takes ~20ms

Is it something you can and are planning to solve, or is it due to having to do a lot of stuff on top of the native Date object and there is not much you can do about it?

[jlfwong]

Agree that this library is super awesome, but do wish it was faster

See: http://jsperf.com/momentjstz

[icambron]

I don't think it's made it into a release yet, so have a look at #39 - it should help a lot here.

[jlfwong]

@icambron Sweeeet. That made a huge difference! Thanks @caseywebdev!

[caseywebdev]

👍 ran into the same thing, memoization helped a lot.

[icambron]

I'm going to leave this ticket open until the release is out.

[dickfickling]

Would it be possible to make a release with the change from #39 as 0.0.4? It's a major improvement, and I'd love to be able to get moment-timezone from npm rather than building from source.

[timrwood]

See #82 as well.

The speed improvements with the rewrite are pretty significant. These are the times for running all the unit tests.

original     63s
memoized     18s
precomputed  7s

[timrwood]

This is released in 0.1.0.

See the performance gains here. http://jsperf.com/moment-timezone-0-1-0/3