Python requests adds params to querystring, where it should be in the body for non-safe HTTP methods (POST/PATCH/DELETE/etc)

[gabn88]

Specifications

• API Version: 3.6.0

Describe the issue

See https://github.com/psf/requests/blob/eea3bbf9ac635f465ee6c9903dc57c677952dafd/src/requests/api.py#L19
the params kwargs goes into the query string, whereas the data goes into the body.

I think this is the issue why I get:

Non-existent query parameter "testmode" for this API call. Did you mean: "include"?

When setting testmode to True.

For your reference this is where it goes wrong in the code:

mollie-api-python/mollie/api/client.py

Line 180 in f5464e4

params["testmode"] = "true"

[fjbender]

Which type of authentication are you using towards the Mollie API?

[gabn88]

We use the 'setup_oauth' method (OAuth2Session authentication).

[geertjanvdenbosch]

Reopened because #361 will be reverted.

[gabn88]

@geertjanvdenbosch I now get error on 3.7.2, but it seems the latest fix is not yet on pypi?

Mollie API call failed: Invalid value for testmode field. Testmode should be boolean true or boolean false.

if you need more info I can also dive into it to get the request params, etc.

[geertjanvdenbosch]

Hi @gabn88,

How do you pass testmode?

[gabn88]

        mollie_client.set_testmode(True)

[geertjanvdenbosch]

Hi @gabn88,

All should be good now!

[gabn88]

@geertjanvdenbosch

Seems to work, thanks!