Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mandates: export missing mandate types from package #372

Closed
wants to merge 1 commit into from
Closed

Mandates: export missing mandate types from package #372

wants to merge 1 commit into from

Conversation

janpaepke
Copy link
Collaborator

This fixes #356

@janpaepke janpaepke added the enhancement Improvements and changes outside of API endpoints. label Sep 11, 2024
@janpaepke janpaepke added this to the 4.0.0 milestone Sep 11, 2024
@janpaepke janpaepke requested a review from Pimm September 11, 2024 11:04
@janpaepke janpaepke force-pushed the chore/export-missing-mandate-types branch 2 times, most recently from cda6250 to a5aece3 Compare September 11, 2024 12:41
@janpaepke janpaepke force-pushed the chore/export-missing-mandate-types branch from a5aece3 to de1c64c Compare September 11, 2024 13:20
@janpaepke janpaepke changed the title export missing mandate types from package Mandates: export missing mandate types from package Sep 11, 2024
@janpaepke janpaepke mentioned this pull request Sep 12, 2024
Open
Pimm
Pimm requested changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@Pimm Pimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These types are intended to be internal.

I would like to better understand how and why they are to be used before we expose them, making them part of the public API.

@Pimm Pimm removed this from the 4.0.0 milestone Sep 16, 2024
@janpaepke
Copy link
Collaborator Author

janpaepke commented Sep 16, 2024 •
edited
Loading

Closing this PR to keep things neat.
We can reopen, should the discussion in #356 conclude to warrant this.

@janpaepke janpaepke closed this Sep 16, 2024
@janpaepke janpaepke added the wontfix This will not be adressed. label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pimm Pimm Pimm requested changes

Assignees
No one assigned
Labels
enhancement Improvements and changes outside of API endpoints. wontfix This will not be adressed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose MandateDetailsCreditCard type
2 participants
@janpaepke @Pimm