Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(directory): Network cards query uses "like" which in some cases results in wrong number of collections shown #4365

Open
dtroelofsprins opened this issue Oct 16, 2024 · 1 comment
Labels
app:directory bug Something isn't working priority Features/bugs that we should not let wait

Comments

@dtroelofsprins
Copy link
Contributor

What version of EMX2 are you using (see footer)
v11.20.6

Describe the bug
Dear Directory team, can you please check the networks linked for BBMRI Cohorts and BBMRI Cohorts DNA on e.g. BBMRI-ERIC Directory
Both show same name (AND ID) on linked pages but with different number of BB/collections included
What can be cause of this? How can this be corrected?

=> Checked and indeed when clicking on BBMRI Cohorts, a different number of collections and biobanks are shown, however, the name and description etc is BBMRI Cohorts DNA. The number of collections is however also not correct.
=> https://directory-playground.molgenis.net shows the right name and description. However there the collection count is still also not OK. First this thought that it was due to not equal EMX2 versions, as playground has the latest version, but after upgrading production to latest, it's still an issue.

After some debugging it turns out that the query is using network ID 'like' , which goes of course wrong in case when getting collections with networkID like bbmri-eric:networkID:EU_BBMRI-ERIC:networks:BBMRI-Cohorts when there is also a network with id: bbmri-eric:networkID:EU_BBMRI-ERIC:networks:BBMRI-Cohorts_DNA ....
This explains the wrong number of collections (as the ones with also _DNA network are shown).
Why however the name/description differs between prod and test is still a bit strange (seems sorting of results or something).

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://directory.bbmri-eric.eu/ERIC/directory/#/collection/bbmri-eric:ID:AT_MUG:collection:BioPersMedCohort'
  2. Click both View BBMRI Cohorts DNA network and View BBMRI Cohorts network
    image
  3. See that the name and description are the same, only number of collections and biobanks differs
    Go to 'https://directory.-playground/BBMRI-ERIC/directory/#/collection/bbmri-eric:ID:AT_MUG:collection:BioPersMedCohort'
  4. Click both View BBMRI Cohorts DNA network and View BBMRI Cohorts network
    image
  5. See that the name and description are fine.

In both cases the number of collections of the BBMRI Cohorts network should be (currently) 205 collections and 58 sub collections, this is however 212 and 58. There are 7 ones shown which only belong to the BBMRI Cohorts DNA network. For example: bbmri-eric:ID:BE_UCL:collection:all_samples

Additional context
I'm wondering if there is any reason why a like is used instead of = in this query?

@dtroelofsprins dtroelofsprins added bug Something isn't working app:directory priority Features/bugs that we should not let wait labels Oct 16, 2024
@dtroelofsprins
Copy link
Contributor Author

It even gets stranger, now production shows the right name and description for BBMRI Cohorts network again. Only thing I can think of is that the server has been restarted...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:directory bug Something isn't working priority Features/bugs that we should not let wait
Projects
None yet
Development

No branches or pull requests

2 participants