Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update remaining uses of 'cohort' to 'sources/resources/etc.' #4341

Closed
Tracked by #4147
hslh opened this issue Oct 11, 2024 · 0 comments · Fixed by #4350
Closed
Tracked by #4147

Update remaining uses of 'cohort' to 'sources/resources/etc.' #4341

hslh opened this issue Oct 11, 2024 · 0 comments · Fixed by #4350

Comments

@hslh
Copy link
Contributor

hslh commented Oct 11, 2024 •
edited
Loading

What version of EMX2 are you using (see footer)
v11.20.0

Describe the bug
In some places the text says 'cohorts', this should be removed or changed to resources/sources.

Landing Page
Catalogue landing page: remove the phrases 'of all (sub)cohorts combined.'
Screenshot 2024-10-11 at 11 23 29

Tooltip 1
Variable explorer harmonisation matrix: change 'cohort' to 'source'
Screenshot 2024-10-11 at 11 26 20

Tooltip 2
Variable detail page: change 'cohort' to 'source'
Screenshot 2024-10-11 at 11 31 49

Desktop (please complete the following information):

  • OS: MacOS Sequoia, Firefox 131.0.0

Additional context
Pop-up for 'about statuses' in the harmonisation matrix (eg on a variable detail page such as this in preview) needs to be brought in line with the new labels for what used to be labelled 'cohorts'. Test plan 4 step 11. See comment below. Plus test plan 4 step 16 (slightly different text here). --> awaiting decision on use of 'sources' and 'resources'
@hslh hslh mentioned this issue Oct 11, 2024
Open
33 tasks
@hslh hslh changed the title Pop-up for 'about statuses' in the harmonisation matrix (eg on a variable detail page such as this in preview) needs to be brought in line with the new labels for what used to be labelled 'cohorts'. Test plan 4 step 11. See comment below. Plus test plan 4 step 16 (slightly different text here). --> awaiting decision on use of 'sources' and 'resources' Update remaining uses of 'cohort' to 'sources/resources/etc.' Oct 11, 2024
@mswertz mswertz mentioned this issue Oct 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(catalogue): use resource or source instead of cohorts molgenis/molgenis-emx2
1 participant
@hslh