Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hyperlinks): hyperlinks can contain parentheses #4273

Open
dtroelofsprins opened this issue Sep 27, 2024 · 2 comments
Open

fix(hyperlinks): hyperlinks can contain parentheses #4273

dtroelofsprins opened this issue Sep 27, 2024 · 2 comments
Labels
bug Something isn't working priority Features/bugs that we should not let wait

Comments

@dtroelofsprins
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently hyperlinks including parentheses are indicated as invalid, although these are valid hyperlink, f.e. https://www.thelancet.com/journals/lancet/article/PIIS0140-6736(07)61086-1/fulltext

Work-around to store it is by replacing the "(" and ")" by %28 and %29

Describe the solution you'd like
As a user I want to be able to save hyperlinks including parentheses without having to encode them

Describe alternatives you've considered
Keep the existing work-around

Additional context
Add any other context or screenshots about the feature request here.

@esthervanenckevort esthervanenckevort added bug Something isn't working priority Features/bugs that we should not let wait labels Oct 21, 2024
@esthervanenckevort
Copy link
Member

Acceptable to translate on the fly to percentage encoding

@chinook25
Copy link
Contributor

I think the best solution is to update the regex that does the check to allow for '(' and ')' (maybe after the first '/'?).

@mswertz mswertz changed the title Hyperlinks can contain parentheses fix(hyperlinks): hyperlinks can contain parentheses Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority Features/bugs that we should not let wait
Projects
None yet
Development

No branches or pull requests

4 participants