fix(catalogue): On variables overview page, filtering on variable name ‘asthma’ and selecting the 4 test cohorts doesn’t display any variables.

[mswertz]

See: $testCatalogue/ssr-catalogue/all/variables?page=1&conditions=[{"id":"search","search":"asthma"},{"id":"collections","conditions":[{"name":"testCohort4"},{"name":"testCohort3"},{"name":"testCohort2"},{"name":"testCohort1”}]}]. (test 7 step 10)

[connoratrug]

what is the expected outcome and why ( what is the link between the variable and resources )

[hslh]

Expected outcome according to test plan: "See that the same list of 15 variables is displayed, with zero mappings for all four cohorts."

[connoratrug]

( what is the link between the variable and resources )

( what is the link between the variable and resources )

[hslh]

What is the behaviour we want to see here? That's something we should answer first.

[hslh]

Discussed this with @EleanorHyde-UMCG , we do want to maintain the original behaviour. For an example, search all variables in the production catalogue, search on 'asthma' and select 'ABCD' cohort. @connoratrug

[EleanorHyde-UMCG]

@EleanorHyde-UMCG

[EleanorHyde-UMCG]

@connoratrug the setting is as follows:

• schema testCatalogue in Acc
• searching within 'all variables', not within a network-specific set of variables
• filter 'asthma' in the search bar, which gives 15 variables
• select the 4 testcohorts
• these 4 testcohorts have zero mappings to any of the 15 'asthma' variables. In test plan 7 we had said that in this situation we should still show all 15 variables and all 4 cohorts (with zero mappings) in an empty harmonisation matrix. This behaviour is also what you currently see in prod (filter on 'asthma' and cohort ABCD as an example). At the moment in acc we see nothing at all, just the message "No variables found with current filters."

Display of all the selected cohorts and variables with an empty harmonisation matrix is in conflict with the expected behaviour described in one of the other test plans and we need to decide within the group whether this was deliberate (distinction between 'all variables' explorer and 'network-specific' explorer perhaps?) or just an oversight. @hslh has written a spec for this and we need to get the group to decide. Let's wait for that decision before continuing with this issue.

[BrendaHijmans]

agebirth_p_fath:

https://data-catalogue-acc.molgeniscloud.org/catalogue/ssr-catalogue/EHEN/variables?page=1&conditions=[{%22id%22:%22resources%22,%22conditions%22:[{%22name%22:%22BIB%22}]}]&view=harmonisation

maar BIB mapping status is 'completed'

https://data-catalogue-acc.molgeniscloud.org/catalogue/ssr-catalogue/EHEN/variables/agebirth_p_fath-LifeCycle-core-LifeCycle?keys={%22name%22:%22agebirth_p_fath%22,%22resource%22:{%22id%22:%22LifeCycle%22},%22dataset%22:{%22name%22:%22core%22,%22resource%22:{%22id%22:%22LifeCycle%22}}}

[hslh]

We've decided to make it internally consistent by not showing empty matrices anymore but simply showing the message 'No variables found with current filters'. So, the behaviour shown here is intended and this issue is no longer relevant.

The BIB/agebirth_p_fath issue is a separate one.

[mswertz]

I have been testing the 'master' and there it seems to be showing this behavior.

[BrendaHijmans]

Note that 'filtering on variable name' is incorrect here: When using the search box, you search through all attributes inside the table Variables that may contain the word 'asthma', also the variable description.