Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reload doesn't work correctly when middleware is changed #1302

Open
ivan-varga-rs opened this issue Sep 22, 2024 · 0 comments
Open

Hot reload doesn't work correctly when middleware is changed #1302

ivan-varga-rs opened this issue Sep 22, 2024 · 0 comments

Comments

@ivan-varga-rs
Copy link

In version 0.15-beta1 when adding a custom middleware hot reload has issues - when middleware is changed all services get re-registered.

Current Behavior

Editing a middleware file re-registers services

Expected Behavior

Services don't multiply :)

Steps to Reproduce

  1. Initialize a project with greeter etc
  2. Add a custom middleware
  3. Call greeter from repl -> get one response from service
  4. Edit middleware file, wait for hot reload
  5. Call greeter from repl -> get two responses from service
  6. Edit again middleware again
  7. Call greeter from repl -> get three responses from service
    image

Reproduce code snippet

Middleware code:

`module.exports = function ExampleMiddleware(broker) {
const enabled = broker.options.hotReload; // or whatever

return {
	name: "HotRebuild",

	localAction(next, action) {
		return function (ctx) {
			console.log("Example example");

			return next(ctx);
		};
	},
};

};
`

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • Moleculer version: v0.15-beta1
  • NodeJS version: v18
  • Operating System: Windows 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant