-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove QueryExpr pattern match to support Ecto 3.12.0 #105
Conversation
please merge! 👍 |
Fix issue with using Torch for users who have Ecto >= 3.12.0 * #479 * mojotech/scrivener_ecto#105
Fix issue with using Torch for users who have Ecto >= 3.12.0 * #479 * mojotech/scrivener_ecto#105
Fix issue with using Torch for users who have Ecto >= 3.12.0 * #479 * mojotech/scrivener_ecto#105
@cblavier I have published a new hex package with this PR/fork applied called torch_scrivener_ecto. It is named this way because I needed this fork for the Torch project that I also maintain. Feel free to use this fork and/or submit any future updates/PR's against this fork directly as well. |
Hi folks. As mentioned in the |
@drewolson We'd be open to taking over maintenance of these two projects under our existing https://github.com/mojotech. We currently maintain the Elixir Torch admin package and a few other smaller elixir packages. Since Torch directly uses and depends on Scrivener we'd be happy to also continue maintenance on this package as well if you are open to it. Here is our hex.pm MojoTech org link as well. |
@cpjolicoeur Sounds great! Please shoot me an email at [email protected] and we can coordinate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this for now to get things unblocked. Will loop back and look at seeing if we need to do this with a more formal object or not in the future.
Ecto replaced
Ecto.Query.QueryExpr
withEcto.Query.ByExpr
since version 3.12.0:See: https://hexdocs.pm/ecto/changelog.html#v3-12-0-2024-08-12
I thought about adding another function and pattern match
Ecto.Query.ByExpr
, but the module is only available since Ecto 3.12.0.