Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QueryExpr pattern match to support Ecto 3.12.0 #105

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

krns
Copy link
Contributor

@krns krns commented Aug 13, 2024

Ecto replaced Ecto.Query.QueryExpr with Ecto.Query.ByExpr since version 3.12.0:

distinct, group_by, order_by and window expressions use the new Ecto.Query.ByExpr struct rather than the old Ecto.Query.QueryExpr struct

See: https://hexdocs.pm/ecto/changelog.html#v3-12-0-2024-08-12

I thought about adding another function and pattern match Ecto.Query.ByExpr, but the module is only available since Ecto 3.12.0.

@cblavier
Copy link

please merge! 👍

cpjolicoeur added a commit to mojotech/torch that referenced this pull request Sep 6, 2024
Fix issue with using Torch for users who have Ecto >= 3.12.0

* #479
* mojotech/scrivener_ecto#105
cpjolicoeur added a commit to mojotech/torch that referenced this pull request Sep 6, 2024
Fix issue with using Torch for users who have Ecto >= 3.12.0

* #479
* mojotech/scrivener_ecto#105
cpjolicoeur added a commit to mojotech/torch that referenced this pull request Sep 6, 2024
Fix issue with using Torch for users who have Ecto >= 3.12.0

* #479
* mojotech/scrivener_ecto#105
@cpjolicoeur
Copy link
Member

@cblavier I have published a new hex package with this PR/fork applied called torch_scrivener_ecto. It is named this way because I needed this fork for the Torch project that I also maintain. Feel free to use this fork and/or submit any future updates/PR's against this fork directly as well.

@drewolson
Copy link
Contributor

Hi folks. As mentioned in the README, I'm not longer actively involved in the elixir community and I do not have time to maintain this package. If folks would like to create a new organization (e.g. elixir-scrivener), I'd be happy to move these repositories (scrivener and scrivener-ecto) to that organization and also move ownership of the hex packages.

@cpjolicoeur
Copy link
Member

cpjolicoeur commented Sep 7, 2024

Hi folks. As mentioned in the README, I'm not longer actively involved in the elixir community and I do not have time to maintain this package. If folks would like to create a new organization (e.g. elixir-scrivener), I'd be happy to move these repositories (scrivener and scrivener-ecto) to that organization and also move ownership of the hex packages.

@drewolson We'd be open to taking over maintenance of these two projects under our existing https://github.com/mojotech. We currently maintain the Elixir Torch admin package and a few other smaller elixir packages. Since Torch directly uses and depends on Scrivener we'd be happy to also continue maintenance on this package as well if you are open to it. Here is our hex.pm MojoTech org link as well.

@drewolson
Copy link
Contributor

@cpjolicoeur Sounds great! Please shoot me an email at [email protected] and we can coordinate.

Copy link
Member

@cpjolicoeur cpjolicoeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this for now to get things unblocked. Will loop back and look at seeing if we need to do this with a more formal object or not in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants