Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing 'first this month' on 2/29 outputs 3/1 #327

Open
seanysun opened this issue Mar 1, 2016 · 2 comments
Open

Parsing 'first this month' on 2/29 outputs 3/1 #327

seanysun opened this issue Mar 1, 2016 · 2 comments
Labels

Comments

@seanysun
Copy link

seanysun commented Mar 1, 2016

Parsing 'first this month' on 2/29 outputs 3/1

[9] pry(main)> Time.now
=> 2016-02-29 14:39:04 -0800
[10] pry(main)> Chronic.parse('first this month')
=> 2016-03-01 12:00:00 -0800

I'd be happy to put together a PR to fix this, but I noticed that no PR's have been merged since 2014. If I submit a fix, is there any chance it will be accepted?

@davispuh
Copy link
Collaborator

davispuh commented Mar 2, 2016

I think this format isn't really supported... and see #316, if you want to make PR do it for my rewrite branch, it's still work in progress and not finished but I'll work on it when I'll have time.

EDIT: actually it seems to be working, but you need to use :context => :past

@frank184
Copy link

frank184 commented Sep 30, 2016

I've noticed this in a project today.

We're Sept 30, 2016 and doing Chronic.parse('this month') returns Oct 1st, 2016.

I would expect 'this month' to be the month that we're currently in...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants