Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow concurrent builds #293

Closed
ottlinger opened this issue Jul 5, 2018 · 4 comments
Closed

Allow concurrent builds #293

ottlinger opened this issue Jul 5, 2018 · 4 comments

Comments

@ottlinger
Copy link

Thanks for the great plugin!

When I integrated it into our builds as follows:
$ versions:display-dependency-updates versions:plugin-updates-report enforcer:display-info -U -B -T8
I get the warning:
21:28:50 [INFO] --------------------------------[ pom ]--------------------------------- 21:28:50 [WARNING] ***************************************************************** 21:28:50 [WARNING] * Your build is requesting parallel execution, but project * 21:28:50 [WARNING] * contains the following plugin(s) that have goals not marked * 21:28:50 [WARNING] * as @threadSafe to support parallel building. * 21:28:50 [WARNING] * While this /may/ work fine, please look for plugin updates * 21:28:50 [WARNING] * and/or request plugins be made thread-safe. * 21:28:50 [WARNING] * If reporting an issue, report it against the plugin in * 21:28:50 [WARNING] * question, not against maven-core * 21:28:50 [WARNING] ***************************************************************** 21:28:50 [WARNING] The following plugins are not marked @threadSafe in 365 FarmNet Monolith Builder: 21:28:50 [WARNING] org.codehaus.mojo:versions-maven-plugin:2.5 21:28:50 [WARNING] Enable debug to see more precisely which goals are not marked @threadSafe. 21:28:50 [WARNING] ***************************************************************** 21:28:50 [INFO]

Can the plugin be made threadSafe by adding the annotation or are there things in the code that are not concurrently executable?

Thanks

@dannil
Copy link
Contributor

dannil commented Jul 10, 2018

This was fixed with #219, my installed version of 2.6-SNAPSHOT with Maven 3.5.2 doesn't output the warning.

@khmarbaise
Copy link
Member

@dannil Thanks reporting this.

@renedewaele
Copy link

I'm still getting this warning using Maven 3.5.4 and version 2.7 of the plugin. See:

* Your build is requesting parallel execution, but project      *
* contains the following plugin(s) that have goals not marked   *
* as @threadSafe to support parallel building.                  *
* While this /may/ work fine, please look for plugin updates    *
* and/or request plugins be made thread-safe.                   *
* If reporting an issue, report it against the plugin in        *
* question, not against maven-core                              *
*****************************************************************
The following plugins are not marked @threadSafe in Flux Capacitor:
org.codehaus.mojo:versions-maven-plugin:2.7
Enable debug to see more precisely which goals are not marked @threadSafe.
*****************************************************************

@khmarbaise
Copy link
Member

Please don't reuse old issue better create a new one.. Also helpful would be how you called the versions plugin and also which version of the plugin you are using ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants