Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dependency-updates-report to configure processDependencies and processDependencyManagement like display-dependency-updates can #46

Closed
bbrouwer opened this issue Jan 5, 2016 · 9 comments
Milestone

Comments

@bbrouwer
Copy link

bbrouwer commented Jan 5, 2016

When using Spring Boot, the dependency management section of my project gets to be enormous. It can take a medium sized project an extra 30 minutes to generate the site because of this. I want to be able to set processDependencyManagement to false to speed up site generation.

When I run display-dependency-updates on my project, it only adds about 2 minutes to the total build time when I set processDependencyManagement to false.

cs01lg pushed a commit to cs01lg/versions-maven-plugin-Issue-46 that referenced this issue Feb 5, 2017
cs01lg pushed a commit to cs01lg/versions-maven-plugin-Issue-46 that referenced this issue Feb 7, 2017
cs01lg pushed a commit to cs01lg/versions-maven-plugin-Issue-46 that referenced this issue Feb 7, 2017
cs01lg added a commit to cs01lg/versions-maven-plugin-Issue-46 that referenced this issue Feb 10, 2017
where processDependencyManagement = true
@PeterWippermann
Copy link

In #129 I have a similar request. Wouldn't it be nice to have a ternary switch?

"Process dependency management section?"

  1. All
  2. Only top level, no transitive or imports
  3. No

cs01lg pushed a commit to cs01lg/versions-maven-plugin-Issue-46 that referenced this issue May 3, 2017
Added processDependencyManagement to the dependency-updates-report goal
This behaves the same as display-dependency-updates goal
cs01lg pushed a commit to cs01lg/versions-maven-plugin-Issue-46 that referenced this issue May 3, 2017
Added processDependencyManagement to the dependency-updates-report goal
This behaves the same as display-dependency-updates goal
@khmarbaise
Copy link
Member

Hm.After taking a deeper look into the pull request I see at a larger number of different things which are solved in this PR. It looks as if you have not correctly rebased your branch and made a new pull request so to see only the changes you have made...I'm not sure here cause I see changes which are made on an branch for maven 3 migration which should never be part of the current mast at the moment....

@khmarbaise khmarbaise added this to the 2.4.1 milestone Jun 15, 2017
@khmarbaise
Copy link
Member

I have taken the liberty to use your code suggestions and added them. Based on your pull request which looks wrong I couldn't integrate it directly. None the less thanks for your contribution.

@PeterWippermann
Copy link

Too bad that you didn't incorporate may feedback from above, @khmarbaise.
And regarding your code attribution, I'm also not sure whether @cs01lg and @bbrouwer are the same person?!

@khmarbaise
Copy link
Member

Hi @PeterWippermann you are talking about the hint for import scope ?

@PeterWippermann
Copy link

yes, why not add an option to process only the top-level dependencies in the POM and exclude their transitive dependencies?

@khmarbaise
Copy link
Member

Ah..If I correctly see this is #129 ?

@bbrouwer
Copy link
Author

Nope. I'm not the same person as @cs01lg

I like the request of #129 as it sounds like a better request than mine here. My situation is the same: Spring Boot with importing a pom's dependencies.

@khmarbaise
Copy link
Member

@bbrouwer Please take a look at #129 and the output of an example run...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants