Add a verification system #209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, fix indentation issues that the ESLint found.
chandler05
reviewed
May 28, 2021
urielsalis
reviewed
May 28, 2021
urielsalis
reviewed
May 28, 2021
Fetching messages at startup, mostly, and improvements to embed creation.
In case the user copy-and-pastes the token from the embed into the comment field under Visual mode, the boldness is copied too. Removing the asterisks fixes this problem.
In case this role ever gives access to extra channels, and the user uses the access incorrectly, it is possible to remove the role from them temporarily (or permanently, if you want it to). Also, this includes a very important fix to adding the Verified role initially.
Simply react to the verification log embed with ✂, and MojiraBot will delete the message, removing the account link.
Previously, VerificationMessageEventHandler read directly from the channel. Now, it reads from the cache, saving time and resources.
Previously, a user who had their verification temporarily removed could run !jira verify again to create a second log message, potentially causing problems. Now, running !jira verify also checks the log channel for a verification, preventing this.
Changed from forEach loop to for loop, to save time.
Allows for deletion.
It's nice to know that the link is correct.
|
I think this is as complete as I'm going to get it, so I am marking this pull request as ready for review. |
Added help for the verify command into the help command's commands.
Marcono1234
reviewed
Jun 15, 2021
Merged
|
Looks like the team is in favor of adding this according to https://discord.com/channels/647810384031645728/647810521713606656/850795026674089985 |
|
I've decided to close this for now. When creating this, I made many choices that are inefficient for the bot, like storing verifications in a Discord channel. After the jira.js and discord.js pull requests are merged, I plan to remake this in a more efficient way. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add a verification system! Implements #98.
Approach
To verify their account, a member will need to:
!jira verify(MojiraBot will send them a 15 character token)link <jira username>The bot will check the ticket for their comment, and if the username and code matches, the accounts will be linked.
This also adds:
!jira whoor!jira whoisto check the account linked to either a Mojira or a Discord account.Future work