Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quoteParty.partySubIdOrTypeId column should not have FK constraint to partyIdentifierType table #284

Closed
bushjames opened this issue Sep 20, 2021 · 4 comments

Comments

@bushjames
Copy link
Contributor

bushjames commented Sep 20, 2021

The subIdOrTypeId of a quote/transfer party should not be limited to values of the enum partyIdentifierType. This field is intended to carry an enum value OR an identifier itself. The foreign key that exists between quoteParty.partySubIdOrTypeId and the partyIdentifierType table forbids an identifier value being used. This constraint should be removed to allow compliance with usecases that do not use identifier type enums.

@elnyry-sam-k
Copy link
Member

Definitely @bushjames (both values should be allowed and shouldn't be limited to the partyIdentifier enum values)..

@mdebarros
Copy link
Member

Hey @bushjames, are you in the process of fixing this, or should we create an issue for the Core-OSS team?

@bushjames
Copy link
Contributor Author

Please can you create an issue for the Core-OSS team @mdebarros . Many thanks.

@mdebarros
Copy link
Member

Please can you create an issue for the Core-OSS team @mdebarros . Many thanks.

Issue created --> mojaloop/project#2506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants