Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ad-hoc message creation with consistent message parsing #878

Closed
11 tasks
lewisdaly opened this issue Jul 24, 2019 · 1 comment
Closed
11 tasks

Replace ad-hoc message creation with consistent message parsing #878

lewisdaly opened this issue Jul 24, 2019 · 1 comment

Comments

@lewisdaly
Copy link
Contributor

Goal:

As an OSS Maintainer I want to replace ad-hoc message creation with a factory method to ensure consistent and reliable message parsing across all services

This ticket is a follow up for #868, wherein some parameters from the notification message were missing, causing downstream errors.

Our tests failed to catch the issue as the mocked messages we were testing against were not consistent with what was in the actual code.

Tasks:

  • Determine whether or not such a factory method exists in central-services-shared or central-services-stream @rmothilal you might be able to help here
  • Apply the method to the following projects:
    • central-ledger
    • ml-api-adapter
    • TODO:

Acceptance Criteria:

  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

  • TBD

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@lewisdaly
Copy link
Contributor Author

Looks out of scope now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant