Change Instanbul to Nyc for coverage on all projects

[rmothilal]

Goal:

As a developer I want to update all services to use nyc instead of istanbul so that we can have the most recently updated dependencies as nyc now replaces the deprecated istanbul

Tasks:

• update package.json files for all services to latest nyc (where applicable) version

• add .nycrc.yml files in root with nyc config or make sure that jest/ava is configured similiarly

• Core APIs first

  • central-services-auth (currently uses Istanbul)(deprecated)
  • central-services-database
  • central-services-error-handling
  • central-services-metrics (uses nyc, missing .nycrc.yml) -> chore(#864): change instanbul to nyc for coverage on all projects central-services-metrics#153
  • central-services-shared
  • central-services-stream
  • central-services-logger
  • central-services-health (uses nyc, missing .nycrc.yml) -> chore(#864): change instanbul to nyc for coverage on all projects central-services-health#245 chore(#864):change instanbul to nyc for coverage on all projects central-services-health#247
  • central-object-store
  • ml-number

• Ensure core dependencies are updated befor doing other APIs

• Other APIs

  • forensic-logging-sidecar (deprecated)
  • forensic-logging-sidecar (deprecated)
  • quoting-service (uses jest with nyc exporter, .nycrc.yml with no code-coverage 90% milestones configured, with jest.config.js with 90% coverage milestones) -> chore(#864): change instanbul to nyc for coverage on all projects quoting-service#279
  • simulator (no unit tests/coverage exists for this project)
  • account-lookup-service
  • central-event-processor (currently uses Istanbul) -> chore(#864): change instanbul to nyc for coverage on all projects central-event-processor#231 chore(#864-2): change instanbul to nyc for coverage on all projects central-event-processor#232
    • Need story to fix code-coverage -> QA improvements for Unit Tests and Code Coverage - central-event-processor #2411
  • event-sidecar
  • event-sdk (uses jest with nyc exporter, missing .nycrc.yml)
  • central-ledger
  • central-settlement
  • email-notifier (currently uses Istanbul) -> chore(#864): change instanbul to nyc for coverage on all projects email-notifier#191 chore(#864-2): change instanbul to nyc for coverage on all projects email-notifier#192
    • Need story to fix code-coverage -> QA improvements for Unit Tests and Code Coverage - email-notifier #2410
  • ml-api-adapter
  • pathfinder-provisioning-client (deprecated)
  • pathfinder-query-client (deprecated)
  • event-stream-processr (currently uses Istanbul) -> chore(#864): change instanbul to nyc for coverage on all projects (#231) event-stream-processor#49
    • Need story to fix missing unit tests, code-coverage and CI/CD checks -> QA improvements for Unit Tests and Code Coverage - event-stream-processr #2412
  • als-oracle-pathfinder (uses ava, with istanbul) chore(#864): change instanbul to nyc for coverage on all projects (#231) als-oracle-pathfinder#57
    • Need story to fix missing code-coverage and CI/CD checks -> QA improvements for Unit Tests and Code Coverage - als-oracle-pathfinder #2413
  • als-consent-oracle (uses jest, with jest.config.js with 90% coverage milestones)
  • oracle-shared-library
  • sdk-standard-components (uses jest, with jest.config.js with 90% coverage milestones)
  • sdk-scheme-adapter (uses jest, with jest.config.js with 90% coverage milestones)
  • transaction-request-service (uses jest)
  • finance-portal-lib (no code coverage tests, being deprecated by finance-portal v2)
  • finance-portal-ui (no code coverage tests, being deprecated by finance-portal v2)
  • finance-portal-backend-service (uses jest, being deprecated by finance-portal v2)
  • auth-service (uses jest, with jest.config.js with 90% coverage milestones)

Acceptance Criteria:

• Code Style & Coverage meets standards

Notes:

Example .nycrc.yml file:

temp-directory: "./.nyc_output"
check-coverage: true
per-file: true
lines: 90
statements: 90
functions: 90
branches: 90
all: true
include: [
  "src/**/*.js"
]
reporter: [
  "lcov",
  "text-summary"
]
exclude: [
  "**/node_modules/**"
]

Pull Requests:

• TBD

Follow-up:

• N/A

Dependencies:

• N/A

Accountability:

• Owner: @rmothilal
• QA/Review: @rmothilal @mdebarros @elnyry