Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET /parties - no JWS headers returned at payeefsp #810

Closed
sri-miriyala opened this issue Jun 12, 2019 · 5 comments
Closed

GET /parties - no JWS headers returned at payeefsp #810

sri-miriyala opened this issue Jun 12, 2019 · 5 comments
Assignees
Milestone

Comments

@sri-miriyala
Copy link

Summary:
After the ALS implementation, In GET /parties call, Switch not forwarding the JWS headers to payeefsp.

Severity:
(High)

Priority:
(medium)
Expected Behavior

When sending GET /parties call from payerfsp, switch is supposed to forward the JWS headers to payeefsp.
Steps to Reproduce

  1. Register a party in payeefsp
  2. Send GET /parties request with all valid params, including JWS headers from payerfsp
  3. In the logs at payeefsp, I see JWS headers are missing.

Specifications

  • Component (if known): ALS
  • Version:
  • Platform:
  • Subsystem:
  • Type of testing: Contract / API
  • Bug found/raised by: SRI
@elnyry-sam-k
Copy link
Member

@sri-miriyala can you please add the specific headers and describe expected behavior explicitly?

@mdebarros mdebarros added the test-bug This is a bug in tests or test automation framework, not a code or functionality issue label Jul 18, 2019
@sri-miriyala
Copy link
Author

Below are the headers that are being sent on the request:
curl -X GET
http://dev1-account-lookup.mojaloop.live/parties/MSISDN/27713803912
-H 'Accept: application/vnd.interoperability.parties+json'
-H 'Content-Type: application/vnd.interoperability.parties+json;version=1.0'
-H 'Date: Sat, 20 Jul 2019 14:24:30 GMT'
-H 'FSPIOP-HTTP-Method: GET'
-H 'FSPIOP-Signature: {"signature":"iU4GBXSfY8twZMj1zXX1CTe3LDO8Zvgui53icrriBxCUF_wltQmnjgWLWI4ZUEueVeOeTbDPBZazpBWYvBYpl5WJSUoXi14nVlangcsmu2vYkQUPmHtjOW-yb2ng6_aPfwd7oHLWrWzcsjTF-S4dW7GZRPHEbY_qCOhEwmmMOnE1FWF1OLvP0dM0r4y7FlnrZNhmuVIFhk_pMbEC44rtQmMFv4pm4EVGqmIm3eyXz0GkX8q_O1kGBoyIeV_P6RRcZ0nL6YUVMhPFSLJo6CIhL2zPm54Qdl2nVzDFWn_shVyV0Cl5vpcMJxJ--O_Zcbmpv6lxqDdygTC782Ob3CNMvg","protectedHeader":"eyJhbGciOiJSUzI1NiIsIkZTUElPUC1VUkkiOiIvdHJhbnNmZXJzIiwiRlNQSU9QLUhUVFAtTWV0aG9kIjoiUE9TVCIsIkZTUElPUC1Tb3VyY2UiOiJPTUwiLCJGU1BJT1AtRGVzdGluYXRpb24iOiJNVE5Nb2JpbGVNb25leSIsIkRhdGUiOiIifQ"}'
-H 'FSPIOP-Source: payerfsp'
-H 'FSPIOP-URI: /parties/MSISDN/27713803912'
-H 'Postman-Token: 8997ac7b-21d7-4b37-920a-3dcca08ab02d'
-H 'cache-control: no-cache'

Below are the headers that are received at the payeefsp side:
Screen Shot 2019-07-20 at 10 28 28 AM

As you can notice in the output, Accept, fspiop-method, fspiop-uri headers are not forwarded by ALS service to payeefsp

@elnyry-sam-k elnyry-sam-k removed the test-bug This is a bug in tests or test automation framework, not a code or functionality issue label Jul 22, 2019
@elnyry-sam-k elnyry-sam-k added this to the Sprint 7.2 milestone Jul 22, 2019
@elnyry-sam-k elnyry-sam-k modified the milestones: Sprint 7.2, Sprint 7.3 Aug 5, 2019
@elnyry-sam-k
Copy link
Member

To be addressed as part of #902.. @rmothilal please confirm. Thank you..

@elnyry-sam-k
Copy link
Member

@rmothilal just FYI, this is still reproducible on the latest DEV2 envt (v7.3.1-snapshot of ALS)

@elnyry-sam-k
Copy link
Member

Fixed now.. Please re-open if there's a repro. (Fixed in helm version v7.4.0, ALS 7.4.0-snapshot)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants