Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement batch functionality in the position handler for fulfil actions #3524

Closed
13 of 21 tasks
PaulGregoryBaker opened this issue Sep 19, 2023 · 1 comment
Closed
13 of 21 tasks

Comments

@PaulGregoryBaker
Copy link

PaulGregoryBaker commented Sep 19, 2023

Goal:

As a development team working on mojaloop transfer performance enhancement
I want to Implement the transfer batching design in the position handler for the fulfil action
so that I get the performance benefit of batching

Acceptance Criteria:

  • Verify that the batch is designed for the position handler as defined in story Fix the transfer batching design for the position handler #3488 for the following actions
    • fulfil
  • Verify that the position handler characterisation is performed with the batch functionality implemented
  • Verify that the happy path functional tests pass
  • Verify that unit test are in place
  • Build integration test for negative scenarios for the following actions
    • fulfil

Complexity: <High|Medium|Low> > A short comment to remind the reason for the rating

Uncertainty: <High|Medium|Low> > A short comment to remind the reason for the rating


Tasks:

  • Add fulfil domain logic
  • Add unit tests
  • Add integration tests
  • Smoke test in test harness
  • Characterize new batch functionality
  • Add reserve logic and tests

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

  • TBD

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@PaulGregoryBaker
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment