Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK Scheme Adapter] Add Inbound handler for quotes (Payee DFSP De-Multiplexing) #2905

Open
21 tasks
PaulGregoryBaker opened this issue Aug 30, 2022 · 0 comments
Open
21 tasks
Labels
core-dev-squad oss-bulk Mojaloop bulk implementation and support story to-be-refined This story is ready to be groomed

Comments

@PaulGregoryBaker
Copy link

PaulGregoryBaker commented Aug 30, 2022

Goal:

As a DFSP connected to Mojaloop
I would like to use the bulk transfers use case
So that I can integrate bulk load disbursement calls with my core banking system

Note:
The purpose of this story is to enable the Payee SDK-Scheme-Adpater config HasSupportForBulkQuotes = false option.
I.e. so that the bulk implementation for quotes is not required for every DFSP connected in the switch.

Limitations
This story covers flows steps in 41 - 48 in the sequence diagram. I.e. the implementation of steps 45, 46, 47

Sequence Diagram
The sequence diagram of this design can be accessed here.

Detailed Design
The details of the design implementation are specified here

Acceptance Criteria

  • Verify that steps 41 - 48 in the sequence diagram are implemented
    • Verify that the Incoming API’s are implemented in line with above Epic design
      • Post /bulkquotes
      • PUT /bulkquotes callback
    • Verify that the POST /bulkquote call is split into n synchronous POST /quoterequests calls
    • Verify that the results for both happy and unhappy quote requests are consolidate and returned in the PUT /bulkquotes callback
  • Verify that the bulk transfers API error cases are implemented in the SDK Scheme Adapter
  • Verify that if a transfer is delayed by more than the bulk Expiration time are aborted
  • Verify that failed quotes abort the transfer with error
  • Verify that the bulkExpiration is taken into account when setting quote expirations
  • Verify that automated CICD test are added to cover this functionality
  • Verify that Incoming Event handler rules are added to complete the flow as designed links above.
  • Verify the the Incoming Command handler is has commands added that as designed links above.
  • Verify that the Incoming Command handler has narrow integration tests

Complexity: <High|Medium|Low> > A short comment to remind the reason for the rating

Uncertainty: <High|Medium|Low> > A short comment to remind the reason for the rating


Tasks:

  • TBD [ @? ]

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

  • TBD

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@PaulGregoryBaker PaulGregoryBaker added core-dev-squad oss-bulk Mojaloop bulk implementation and support story labels Aug 30, 2022
@PaulGregoryBaker PaulGregoryBaker added the to-be-refined This story is ready to be groomed label Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-dev-squad oss-bulk Mojaloop bulk implementation and support story to-be-refined This story is ready to be groomed
Projects
None yet
Development

No branches or pull requests

1 participant