Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PR request title check to all core repos #2004

Closed
93 tasks
lewisdaly opened this issue Feb 2, 2021 · 1 comment
Closed
93 tasks

add PR request title check to all core repos #2004

lewisdaly opened this issue Feb 2, 2021 · 1 comment
Assignees
Labels
security Mojaloop Platform Quality and Security Initiative story
Milestone

Comments

@lewisdaly
Copy link
Contributor

lewisdaly commented Feb 2, 2021

Goal:

As a oss maintainer

I want to enforce conventional commit titles on github PRs

so that we can start to automate releases

Acceptance Criteria:

  • PR title check applied to all repos

Tasks:

  • add the Pr title check orb from Mojaloop's set of circleci orbs
  • update ci/cd files where required
  • apply to the following repos:
    • account-lookup-service
    • bulk-api-adapter
    • central-event-processor
    • central-ledger
    • central-object-store
    • central-settlement
    • email-notifier
    • event-sidecar
    • event-stream-processor
    • finance-portal-backend-service
    • finance-portal-ui
    • ml-api-adapter
    • ml-operator
    • ml-testing-toolkit
    • ml-testing-toolkit-ui
    • mojaloop-simulator
    • operator-settlement
    • quoting-service
    • sdk-scheme-adapter
    • settlement-management
    • simulator
    • transaction-requests-service
    • apm-agent-nodejs
    • apm-agent-nodejs-opentracing
    • central-services-auth
    • central-services-database
    • central-services-error-handling
    • central-services-health
    • central-services-logger
    • central-services-metrics
    • central-services-shared
    • central-services-stream
    • event-sdk
    • finance-portal-lib
    • ml-number
    • ml-schema-validator
    • ml-testing-toolkit-shared-lib
    • postman
    • sdk-standard-components
    • api-snippets
    • documentation
    • helm
    • mojaloop-specification
    • hackathon
    • hackathon-docs
    • mojaloop-business-docs

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

Follow-up:

  • The following core- repos need to be updated to the circlei 2.1 template:
    • central-object-store
    • central-services-auth
    • central-services-database
    • central-services-error-handling
    • central-services-health
    • central-services-logger
    • central-services-shared
    • central-services-stream
    • finance-portal-lib
    • ml-number
    • ml-schema-validator
    • ml-testing-toolkit
    • ml-testing-toolkit-shared-lib
    • ml-testing-toolkit-ui
    • mock-pathfinder
    • mojaloop-specification
    • postman
    • sdk-standard-components
    • test-scripts

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@lewisdaly lewisdaly added security Mojaloop Platform Quality and Security Initiative story labels Feb 2, 2021
@lewisdaly lewisdaly added this to the Sprint 13.1 milestone Feb 2, 2021
@lewisdaly lewisdaly self-assigned this Feb 2, 2021
@lewisdaly
Copy link
Contributor Author

I've started opening the mass PRs, will open the rest once the first few get approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Mojaloop Platform Quality and Security Initiative story
Projects
None yet
Development

No branches or pull requests

1 participant