Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit tests coverage for quoting-service (part 1) #1041

Closed
7 of 22 tasks
ggrg opened this issue Oct 31, 2019 · 1 comment
Closed
7 of 22 tasks

Improve unit tests coverage for quoting-service (part 1) #1041

ggrg opened this issue Oct 31, 2019 · 1 comment
Assignees
Labels
Milestone

Comments

@ggrg
Copy link
Member

ggrg commented Oct 31, 2019

Goal:

As a ML OSS code-base maintainer
I want to provide full unit test coverage for Quote Model script
so that the code-quality needed for quoting-service can be achieved and maintained

Tasks:

  • Provide full unit tests coverage for model/quotes.js [@ggrg]
    • handleQuoteUpdate [@ggrg]
    • forwardQuoteUpdate [@ggrg]
    • handleQuoteUpdateResend [@ggrg] d481c56
    • handleQuoteError
    • handleQuoteGet
    • forwardQuoteGet
    • handleException
    • sendErrorCallback
    • checkDuplicateQuoteRequest
    • checkDuplicateQuoteResponse
    • removeEmptyKeys
    • calculateRequestHash
    • generateRequestHeaders
    • writeLog

Acceptance Criteria:

  • Full unit tests coverage for Quote Model
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.

Pull Requests:

Follow-up:

Dependencies:

Accountability:

@ggrg
Copy link
Member Author

ggrg commented Nov 1, 2019

Start:

image

Current:

image

@ggrg ggrg changed the title Improve unit tests coverage for quoting-service Improve unit tests coverage for quoting-service (part 1) Nov 4, 2019
@ggrg ggrg closed this as completed Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants