chore(mojaloop/#3461): nodejs upgrade #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronreynoza
requested review from
vijayg10,
mdebarros and
elnyry-sam-k
as code owners
vijayg10
reviewed
Sep 26, 2023
|
@aaronreynoza I think .versionrc.js file is missing in this PR |
vijayg10
reviewed
Sep 26, 2023
audit-ci.jsonc
Outdated
Comment on lines
8
to
10
| "GHSA-p8p7-x288-28g6", | ||
| "GHSA-c2qf-rxjj-qqgw", | ||
| "GHSA-72xf-g2v4-qvf3" |
There was a problem hiding this comment.
Can you add some comments to indicate why these are in exception list?
There was a problem hiding this comment.
added a comment and created an issue to change library since the request library is deprecated: mojaloop/project#3545
oderayi
requested changes
Sep 27, 2023
oderayi
requested changes
Oct 10, 2023
Co-authored-by: Steven Oderayi <[email protected]>
oderayi
approved these changes
Oct 11, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore(mojaloop/#3461): nodejs upgrade - mojaloop/project#3461