feat(mojaloop/#2092): upgrade nodeJS version for core services (#61) #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebarros
requested review from
vgenev,
elnyry-sam-k,
lewisdaly,
oderayi and
shashi165
as code owners
…oop#61) feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092 - standardised CI scripts - updated docker-compose files to work correctly - fixed lint issues - updated .nvmrc to latest LTS version - added standard CI scripts/config to package.json: release, snapshot, standard-version, etc - updated gitignore to include test/results and IGNORE patterns - updated README with standard auto-release information - Fixed imports - Cleaned up Package.json - replaced npm-audit-resolves with audit-ci and added an applicable `audit-ci.jsonc` file with an audit allowList as per [mojaloop/design-authority-project/issues/92](mojaloop/design-authority-project#92) - added safeguards for uncaught promises as required by Node v16 or otherwise the process will terminate in such an advent (possibly due to the legacy RXJS dependency) Notes: - Helm chart mountPaths need to be updated from `/opt/central-event-processor` to `/opt/app` as follows: ```YAML volumeMounts: - mountPath: /opt/app/config name: <deployment-name> ``` BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses `/opt/app` instead of `/opt/central-event-processor` which will impact config mounts.
mdebarros
force-pushed
the
feat/#2092-Upgrade-NodeJS-Version-for-core-services-v2
branch
from
9db5a85 to
bcae8f1
Compare
|
This is looking good to me, run a |
vijayg10
approved these changes
Jul 26, 2022
elnyry-sam-k
approved these changes
Jul 26, 2022
mdebarros
added a commit
that referenced
this pull request
Jul 26, 2022
…243) feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092 - standardised CI scripts - updated docker-compose files to work correctly - fixed lint issues - updated .nvmrc to latest LTS version - added standard CI scripts/config to package.json: release, snapshot, standard-version, etc - updated gitignore to include standard IGNORE patterns - updated README with standard auto-release information - Fixed imports - Cleaned up Package.json - replaced npm-audit-resolves with audit-ci and added an applicable `audit-ci.jsonc` file with an audit allowList as per [mojaloop/design-authority-project/issues/92](mojaloop/design-authority-project#92) - added safeguards for uncaught promises as required by Node v16 or otherwise the process will terminate in such an advent (possibly due to the legacy RXJS dependency Notes: - Helm chart mountPaths need to be updated from `/opt/central-event-processor` to `/opt/app` as follows: ```YAML volumeMounts: - mountPath: /opt/app/config name: <deployment-name> ``` BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses `/opt/app` instead of `/opt/central-event-processor` which will impact config mounts.
mdebarros
added a commit
that referenced
this pull request
Jul 26, 2022
…243) feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092 - standardised CI scripts - updated docker-compose files to work correctly - fixed lint issues - updated .nvmrc to latest LTS version - added standard CI scripts/config to package.json: release, snapshot, standard-version, etc - updated gitignore to include standard IGNORE patterns - updated README with standard auto-release information - Fixed imports - Cleaned up Package.json - replaced npm-audit-resolves with audit-ci and added an applicable `audit-ci.jsonc` file with an audit allowList as per [mojaloop/design-authority-project/issues/92](mojaloop/design-authority-project#92) - added safeguards for uncaught promises as required by Node v16 or otherwise the process will terminate in such an advent (possibly due to the legacy RXJS dependency Notes: - Helm chart mountPaths need to be updated from `/opt/central-event-processor` to `/opt/app` as follows: ```YAML volumeMounts: - mountPath: /opt/app/config name: <deployment-name> ``` BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses `/opt/app` instead of `/opt/central-event-processor` which will impact config mounts.
mdebarros
added a commit
that referenced
this pull request
Jul 26, 2022
…243) feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092 - standardised CI scripts - updated docker-compose files to work correctly - fixed lint issues - updated .nvmrc to latest LTS version - added standard CI scripts/config to package.json: release, snapshot, standard-version, etc - updated gitignore to include standard IGNORE patterns - updated README with standard auto-release information - Fixed imports - Cleaned up Package.json - replaced npm-audit-resolves with audit-ci and added an applicable `audit-ci.jsonc` file with an audit allowList as per [mojaloop/design-authority-project/issues/92](mojaloop/design-authority-project#92) - added safeguards for uncaught promises as required by Node v16 or otherwise the process will terminate in such an advent (possibly due to the legacy RXJS dependency Notes: - Helm chart mountPaths need to be updated from `/opt/central-event-processor` to `/opt/app` as follows: ```YAML volumeMounts: - mountPath: /opt/app/config name: <deployment-name> ``` BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses `/opt/app` instead of `/opt/central-event-processor` which will impact config mounts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092
audit-ci.jsoncfile with an audit allowList as per mojaloop/design-authority-project/issues/92Notes:
/opt/central-event-processorto/opt/appas follows:BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses
/opt/appinstead of/opt/central-event-processorwhich will impact config mounts.