From b8868c84e9c75bf788ab7daeded4f0a32937f189 Mon Sep 17 00:00:00 2001 From: litleleprikon Date: Wed, 2 Oct 2019 11:51:02 +0500 Subject: [PATCH 1/2] ci: Switch off go modules for gometalinter Gometalinter have known issue with downloading linters using go modules alecthomas/gometalinter#521. Switch off gomodules for linter target in Makefile. --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index e7c3c0024..b190d664b 100644 --- a/Makefile +++ b/Makefile @@ -29,8 +29,8 @@ prepare: .PHONY: lint lint: prepare go get -u github.com/alecthomas/gometalinter - gometalinter --install - gometalinter ./... --aggregate --vendor --skip mock --disable=errcheck --disable=gocyclo --disable=gosec --deadline=5m + GO111MODULE=off gometalinter --install + GO111MODULE=off gometalinter ./... --aggregate --vendor --skip mock --disable=errcheck --disable=gocyclo --disable=gosec --deadline=5m .PHONY: test test: prepare From b2e90ec638a688cfd82816537260a723be0bf8f9 Mon Sep 17 00:00:00 2001 From: litleleprikon Date: Wed, 2 Oct 2019 11:21:59 +0500 Subject: [PATCH 2/2] build: Bump go version Go version bumped to 1.13.1 to fix problems occured during migration to go modules. --- .travis.yml | 2 +- Dockerfile.api | 2 +- Dockerfile.checker | 2 +- Dockerfile.filter | 2 +- Dockerfile.notifier | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.travis.yml b/.travis.yml index 71a9962bd..ccfcc065a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,7 +4,7 @@ services: - redis-server language: go go: - - 1.12.6 + - 1.13.1 git: depth: 1000 addons: diff --git a/Dockerfile.api b/Dockerfile.api index b15d6855d..60d968e2b 100644 --- a/Dockerfile.api +++ b/Dockerfile.api @@ -1,4 +1,4 @@ -FROM golang:1.12.6 as builder +FROM golang:1.13.1 as builder RUN go get github.com/kardianos/govendor diff --git a/Dockerfile.checker b/Dockerfile.checker index c513b02b3..2f9ff68ea 100644 --- a/Dockerfile.checker +++ b/Dockerfile.checker @@ -1,4 +1,4 @@ -FROM golang:1.12.6 as builder +FROM golang:1.13.1 as builder RUN go get github.com/kardianos/govendor diff --git a/Dockerfile.filter b/Dockerfile.filter index 0fb71ae56..d0a9494c0 100644 --- a/Dockerfile.filter +++ b/Dockerfile.filter @@ -1,4 +1,4 @@ -FROM golang:1.12.6 as builder +FROM golang:1.13.1 as builder RUN go get github.com/kardianos/govendor diff --git a/Dockerfile.notifier b/Dockerfile.notifier index 15b60f032..2f9576641 100644 --- a/Dockerfile.notifier +++ b/Dockerfile.notifier @@ -1,4 +1,4 @@ -FROM golang:1.12.6 as builder +FROM golang:1.13.1 as builder RUN go get github.com/kardianos/govendor