-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: trigger name limit #1080
Merged
Merged
feat: trigger name limit #1080
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
20fd82f
feat: add limit for trigger
AleksandrMatsko 4845fc3
test: fix broken
AleksandrMatsko 20c9678
test: for validating trigger name
AleksandrMatsko e17aa33
style: use linter
AleksandrMatsko b413fb3
refactor: make some errors in dto private
AleksandrMatsko d28871c
refactor: move code from limits package to api
AleksandrMatsko 1a64d49
refactor: move number to constant
AleksandrMatsko b389960
merge master into feat/trigger-name-limit
AleksandrMatsko f101d93
merge master into feat/trigger-name-limit
AleksandrMatsko d2f045c
merge master into feat/trigger-name-limit
AleksandrMatsko 7bcb0da
test: fix panics because of no limits config in middleware
AleksandrMatsko dab6158
refactor: errors declaration
AleksandrMatsko ab99cb0
merge master into feat/trigger-name-limit
AleksandrMatsko d374f99
merge master into feat/trigger-name-limit
AleksandrMatsko db40ecb
merge master into feat/trigger-name-limit
AleksandrMatsko f275b9d
merge master into feat/trigger-name-limit
AleksandrMatsko eec4e37
merge origin/master into feat/trigger-name-limit
AleksandrMatsko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а зачем такая вложенность? будут еще какие-то лимиты на триггер?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Мы с Олегом эту штуку обсудили, решили оставить так. Вот аргументы за: