You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the TimestampsFactory.from_fps method always assume that the fps is perfectly constant.
In reality, with some format like m2ts, a "constant" fps isn't actually constant.
Currently, we do all the calculation in ms, but in ns, the equivalent would be: $ns = frame \times {1\over fps} \times 10^9$
So, to properly handle this situation, we would need to add a time_scale parameter to from_fps: def from_fps(fps: Union[int, float, Fraction, Decimal], rounding_method: RoundingMethod, time_scale: Optional[int] = None) -> Timestamps.
But, by default, mkv round the timestamps to milliseconds, so I guess we may need another from_fps method where we could precise the timestamps precision (ex: ms) and if we round them or not.
The text was updated successfully, but these errors were encountered:
Currently, the
TimestampsFactory.from_fps
method always assume that the fps is perfectly constant.In reality, with some format like m2ts, a "constant" fps isn't actually constant.
Currently, we do all the calculation in ms, but in ns, the equivalent would be:$ns = frame \times {1\over fps} \times 10^9$
But, for m2ts file, it is:
For a example, see the end of the message here.
So, to properly handle this situation, we would need to add a
time_scale
parameter tofrom_fps
:def from_fps(fps: Union[int, float, Fraction, Decimal], rounding_method: RoundingMethod, time_scale: Optional[int] = None) -> Timestamps
.But, by default, mkv round the timestamps to milliseconds, so I guess we may need another from_fps method where we could precise the timestamps precision (ex: ms) and if we round them or not.
The text was updated successfully, but these errors were encountered: