Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Use Composer instead of Git submodules? #9

Open
hassankhan opened this issue Mar 5, 2015 · 6 comments
Open

Use Composer instead of Git submodules? #9

hassankhan opened this issue Mar 5, 2015 · 6 comments

Comments

@hassankhan
Copy link

Happy to create a PR if necessary

@mohatt
Copy link
Owner

mohatt commented Mar 6, 2015

Thanks @hassankhan for your suggestion. I have already considered using Composer for managing Dashbrew dependencies but currently I think Git submodules is doing just fine given the nature of the project and the minimal dependencies :). It will also make Dashbrew installation procedure simple by avoiding composer install command so that people can be up and running in no time.

@mohatt mohatt closed this as completed Mar 6, 2015
@hassankhan
Copy link
Author

Well you could always package Dashbrew into a PHAR. composer install can be done easily by any user, and you could set up the provisioner to run it surely?

@mohatt
Copy link
Owner

mohatt commented Mar 6, 2015

Well, using a PHAR may not be a good solution here because the dependencies are being used by both CLI (i.e. Dashbrew Provisioner) and web interfaces.
However, the idea of running composer install as part of the provisioning process sounds pretty good 👍. I will make sure to implement it in the next release. Thank you :-) .

@mohatt mohatt reopened this Mar 6, 2015
@DomagojGojak
Copy link
Contributor

Hi guys! I think that it would be better just to let users manually update the composer when they need to since that is a practice that they are already used to + vagrant provision will then maintain current time to do the provisioning. Another neat thing is that this would open a way to make dashbrew installable using the composer itself and then dashbrew could use the composer post update commands to do the provisioning which would lead to dashbrew installation by a single line in the terminal. Let me know what you guys think. Also, I would be happy to create the PR as well if needed. :-)

@mathewpeterson
Copy link

+1 to getting the dashbrew provisioner into a composer package. By doing this, we could more easily integrate it into our own toolchain.

@hassankhan
Copy link
Author

Yep, could move all the Dashbrew PHP code to a new repo (dashbrew-core?) and have Composer install that onto the VM. If @mdkholy's cool with it, could someone cut a branch and we can maybe get some code up? Happy to do it myself

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants