-
Notifications
You must be signed in to change notification settings - Fork 38
Use Composer instead of Git submodules? #9
Comments
Thanks @hassankhan for your suggestion. I have already considered using Composer for managing Dashbrew dependencies but currently I think Git submodules is doing just fine given the nature of the project and the minimal dependencies :). It will also make Dashbrew installation procedure simple by avoiding |
Well you could always package Dashbrew into a PHAR. |
Well, using a PHAR may not be a good solution here because the dependencies are being used by both CLI (i.e. Dashbrew Provisioner) and web interfaces. |
Hi guys! I think that it would be better just to let users manually update the composer when they need to since that is a practice that they are already used to + vagrant provision will then maintain current time to do the provisioning. Another neat thing is that this would open a way to make dashbrew installable using the composer itself and then dashbrew could use the composer post update commands to do the provisioning which would lead to dashbrew installation by a single line in the terminal. Let me know what you guys think. Also, I would be happy to create the PR as well if needed. :-) |
+1 to getting the dashbrew provisioner into a composer package. By doing this, we could more easily integrate it into our own toolchain. |
Yep, could move all the Dashbrew PHP code to a new repo (dashbrew-core?) and have Composer install that onto the VM. If @mdkholy's cool with it, could someone cut a branch and we can maybe get some code up? Happy to do it myself |
Happy to create a PR if necessary
The text was updated successfully, but these errors were encountered: