Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add production instructions to the Quick Start Guide #3332

Open
5 tasks done
rusmux opened this issue Dec 9, 2024 · 1 comment
Open
5 tasks done

Add production instructions to the Quick Start Guide #3332

rusmux opened this issue Dec 9, 2024 · 1 comment

Comments

@rusmux
Copy link

rusmux commented Dec 9, 2024

Describe the bug

In the Quick Start Guide the instructions are for development only (pnpm run dev). When trying to create a production build (pnpm build && pnpm preview) I encountered a CORS error (#3199), and after fixing it, 404 error codes (#2528). After spending some time searching through the issues list, I fixed these issues, however, I think it would be useful to add production instructions (add headers, change public path), or at least mentions, to the guide

Reproduction

https://module-federation.io/guide/start/quick-start.html

Used Package Manager

pnpm

System Info

System:
    OS: macOS 15.1.1
    CPU: (8) arm64 Apple M1
    Memory: 172.28 MB / 8.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 23.1.0 - ~/.nvm/versions/node/v23.1.0/bin/node
    npm: 10.9.1 - ~/.nvm/versions/node/v23.1.0/bin/npm
    pnpm: 9.15.0 - ~/Library/pnpm/pnpm
  Browsers:
    Chrome: 131.0.6778.109
    Safari: 18.1.1

Validations

@rusmux rusmux changed the title Add production instructions to Quick Start Guide Add production instructions to the Quick Start Guide Dec 9, 2024
@ScriptedAlchemy
Copy link
Member

Feel free to send a PR and get it started with some basic notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants