Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-router-dom dependency and compatibility v7 #3267

Open
2 tasks done
douglaszaltron opened this issue Nov 22, 2024 · 1 comment
Open
2 tasks done

Update react-router-dom dependency and compatibility v7 #3267

douglaszaltron opened this issue Nov 22, 2024 · 1 comment

Comments

@douglaszaltron
Copy link

douglaszaltron commented Nov 22, 2024

Clear and concise description of the problem

About bridge/bridge-react package

Current Situation

  • Current dependency: "react-router-dom": ">=4"
  • react-router-dom is migrating to version 7
  • Package will be renamed to just react-router

Issue Description

react-router-dom is moving towards version 7 and will be changing its package name to just react-router. Given this upcoming change, do we have any plans or movement to support the new react-router package in bridge?

Questions

  • Is there a migration plan?
  • Should we start accepting both packages?
  • What's the compatibility impact?

Suggested solution

Although I understand that the transition to v7 was designed to be to be non-breaking, I have concerns about the package name. I believe we should support both versions.

The migration to just react-router is inevitable. 🤔

Alternative

No response

Additional context

No response

Validations

  • Read the Contributing Guidelines.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@danpeen
Copy link
Contributor

danpeen commented Nov 27, 2024

Thanks for your feedback, we are aware of this issue too, we do need to be compatible with this change in the future, we will adjust the implementation of bridge to be compatible with react-router-dom v7, thank you again~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants