-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] @module-federation/enhanced + Angular example #3009
Comments
Hey Alex. What i would suggest is we loop in @zackarychapple and @Coly010 who both have vastly more experience in angular + federaiton. I know @Coly010 just got angular builds working with rspack, and NX team most likely knows how what needs to be done in modern angular etc, and of course would love an update the information on this page as well. |
The import bootstrap should no longer be needed if you set That said we should include it in the docs like it is elsewhere |
Just do
And you’ll have an Angular MF setup using |
thats fine, as long as he has a angular + federation v2 reference. |
But it's not so simple when it comes to the shared packages. We use the Nx project graph to figure out the packages that need to be shared and the version at which to share them. General rule of thumb if doing it manually with Angular is to share all angular runtime packages that exist in the package.json, including any secondary entrypoints, at the version currently installed. use
|
someone shipped a example with federation/vite package. I have not tried it tho |
Stale issue message |
@swalker326 want to post the link to your example? |
Here is what I got https://github.com/swalker326/react-angular-interop |
Clear and concise description of the problem
As a dev using
@module-federation/enhanced
, I would love an example repo showing the set up I need to use@module-federation/enhanced
in my angular projects.Currently, I am following the truly wonderful documentation page on angular and mf enhanced.
It is a fantastic resource and I am loving all the new documentation sites.
I notice there is one step missing from this page that is on the previous example here, which is adding the
bootstrap.ts
async boundary.I think maybe there could be some other steps missing because I cannot seem to follow the guide and make it work on my own.
Suggested solution
One idea we could collaborate on is:
@module-federation/enhanced
in the MF Examples repo, based on the guide in the doc siteAlternative
One alternative approach could be:
Update the documentation page with the complete source code needed, using collapsable blocks of content to prevent the documentation from becoming too verbose.
Additional context
I am so deeply appreciative of all the OSS work the Byte infra and MF teams do.
Thank you so much for your consideration and support on this request.
If there is interest in this request, I would love to help however I can, just need some guidance on properly configuring
@module-federation/enhanced
+ Angular.Validations
The text was updated successfully, but these errors were encountered: