Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning after upgrading to React v.16.9.0 #15

Open
itsnorbertkalacska opened this issue Sep 5, 2019 · 0 comments
Open

Warning after upgrading to React v.16.9.0 #15

itsnorbertkalacska opened this issue Sep 5, 2019 · 0 comments

Comments

@itsnorbertkalacska
Copy link
Contributor

Hey!

It's me again 😁

So we're still using your package. And recently we upgraded react and react-dom to v16.9.0. After the upgrade we're receiving the following warning:
62850010-f07e8e00-bce1-11e9-9512-a7269d012bca

We know you haven't upgraded react-responsive because of this issue: #9

However we would like to get rid of the warning. Do you think we can find a solution?

We found a not really nice workaround this:

const ResponsiveUglyWorkAround = (props) => (
    <React.Fragment>
        <br style={{ display: 'none' }} />
        <MediaQuery {...props} />
        <br style={{ display: 'none' }} />
    </React.Fragment>
);

as explained here: yocontra/react-responsive#162 (comment)

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant