Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New .gitify dump-method writes "api_key" and omits original "credential_file"-location #433

Open
sebastian-marinescu opened this issue Apr 10, 2023 · 1 comment
Labels

Comments

@sebastian-marinescu
Copy link
Contributor

sebastian-marinescu commented Apr 10, 2023

Summary

I updated to the latest Gitify. The extraction of package-versions works great.

But on the package-provider part, instead of the old/original credential_file,
it now puts username and api_key, but uses the credential_file-filename:

image

image

Step to reproduce

Upgrade to Gitify 2.0.1 and extract a Gitify-powered setup.

Observed behavior

Instead of the old/original credential_file it adds username and api_key.
The api_key is the old/original credential_file-filename (without correct location).

Update: I just noticed it also creates the credential files in the web-root 🤔

Expected behavior

I would expect (and prefer) to have the credential_file in the package-provider-section, if provided before.
I don't want the username and api_key inside my .gitify file, as it resides in the public web-root.

Environment

Gitify 2.0.1
MODX 2.8.5
PHP 8.0.28

@sebastian-marinescu
Copy link
Contributor Author

To clarify:

  • My .gitify is in the web-root, but normally not accessible because of .htaccess-restrictions
  • My .gitify is also in the repository I could give access to a client
  • For now I fixed credential_file manually back, and will continue to do so on extract

@Mark-H Mark-H added the bug label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants