Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracted plugin file doesn't contain all properties #216

Open
Kookabura opened this issue Feb 24, 2017 · 1 comment
Open

Extracted plugin file doesn't contain all properties #216

Kookabura opened this issue Feb 24, 2017 · 1 comment

Comments

@Kookabura
Copy link

Kookabura commented Feb 24, 2017

Summary

Quick summary what's this issue about.
Extracted plugin file doesn't contain all properties. There is no disabled and static for example.

Step to reproduce

How to reproduce the issue, including custom code if needed.
Plugins section config:

plugins:
        class: modPlugin
        primary: name
        extension: .php

Gitify extract

Observed behavior

How it behaved after following steps above.

id: 5
source: 1
name: miniShop2
category: miniShop2
properties: 'a:0:{}'
static_file: core/components/minishop2/elements/plugins/plugin.minishop2.php

Expected behavior

How it should behave after following steps above.

id: 5
source: 1
name: miniShop2
category: miniShop2
properties: 'a:0:{}'
disabled: 1
static: 0
static_file: core/components/minishop2/elements/plugins/plugin.minishop2.php

Environment

Gitify version, MODX version, Operating System, MySQL version, PHP version, etc.
Gitify version 0.12.0, MODX version 2.4.2, 10.1.17-MariaDB, PHP 5.4.16


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Mark-H
Copy link
Member

Mark-H commented Jun 15, 2018

It only includes keys that are not set to the default value, that's probably what you're seeing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants