Improve and error handling for update and autoupdate features. #3161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main issue:
autoupdate
feature where the bot raisesKeyError
while trying to get thecommit
data. See picture below:The cause of the issue is probably because of the forked repo name is other than
modmail
, so the url cannot be found with the response status404
. The response data would be like:Other:
update
andautoupdate
features.autoupdate
andpost_metadata
loops onon_ready
event.read_before_return
(type: bool) parameter toGitHub.request
method. If set toTrue
,ClientResponse.read()
method will be performed first before returning theClientResponse
object. Useful if we want to do other method like.json()
or.text()
after exiting theClientSession
context manager.