Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config vars for the cooldown warn texts #2865

Closed
Vedinsoh opened this issue Oct 25, 2020 · 6 comments · Fixed by #2875
Closed

Add config vars for the cooldown warn texts #2865

Vedinsoh opened this issue Oct 25, 2020 · 6 comments · Fixed by #2875
Labels
config suggestion New config option staged Staged for next version

Comments

@Vedinsoh
Copy link
Contributor

Vedinsoh commented Oct 25, 2020

Describe the solution you'd like
When someone tries to message the bot while they're on a cooldown, they get a messages such as:

Message not sent!
You must wait for 14 minutes and 43 seconds before you can contact me again.

Would it be possible to add config vars so we can translate them, like we have for thread_auto_close_response etc?

Who will this benefit
Anyone who runs the bot on a server that is not primarily English. It really helps keep up with the consistency (whole bot can be pretty much translated for the end user except for this aspect)

@Vedinsoh Vedinsoh changed the title Add config vars for the cooldown error texts Add config vars for the cooldown warn texts Oct 25, 2020
@Anonymyous678
Copy link

Good idea

@fourjr fourjr added the config suggestion New config option label Oct 28, 2020
@fourjr
Copy link
Collaborator

fourjr commented Nov 5, 2020

Unfortunately, we cannot add full support for such a usecase as the "14 minutes and 43 seconds" is dynamic. The most we can do is allow you to modify the text surrounding the time, such as the config option You must wait for {delta} before you can contact me again..

@Vedinsoh
Copy link
Contributor Author

Vedinsoh commented Nov 5, 2020

Wouldn't it be possible to replace "and" with & and allow us to edit "minutes" and "seconds" separately? That'd be the most elegant way to do it I think.

@fourjr
Copy link
Collaborator

fourjr commented Nov 5, 2020

That would be too much unnecessary config.

@fourjr fourjr added the staged Staged for next version label Nov 5, 2020
@fourjr
Copy link
Collaborator

fourjr commented Nov 5, 2020

Added to v3.7.0-dev3 which is still in development. Will be ready for public release soon.

@Vedinsoh
Copy link
Contributor Author

Vedinsoh commented Nov 5, 2020

I don't see an issue with it if it's optional. It's just good to have it for people who want to customize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config suggestion New config option staged Staged for next version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants