Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set python to 3.7 in docker container and release action #2879

Merged
merged 11 commits into from
Nov 16, 2023
Merged

set python to 3.7 in docker container and release action #2879

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5e31551
set python to 3.7 in docker container and release action
Nov 14, 2023
d3b39ab
make 3.7 option 1
Nov 14, 2023
e8fb8c4
make 3.7 option 1
Nov 14, 2023
dd42e7d
fix continuation line
Nov 15, 2023
7b2fe10
Bumop min python version to 3.7
Nov 15, 2023
5b85619
Add comment about why deadsnakes PPA was used
jaisnan Nov 16, 2023
77f3487
Add check for python version=3.7 and remove os hacks
jaisnan Nov 16, 2023
8967404
Add unit tests
jaisnan Nov 16, 2023
712b769
Add formatting
jaisnan Nov 16, 2023
0b15b0a
Remove version checking flow
jaisnan Nov 16, 2023
fe05a9c
Fix typos
jaisnan Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,15 @@ jobs:
apt-get update
apt-get install -y software-properties-common apt-utils
add-apt-repository ppa:git-core/ppa
add-apt-repository ppa:deadsnakes/ppa
jaisnan marked this conversation as resolved.
Show resolved Hide resolved
apt-get update
apt-get install -y \
build-essential bash-completion curl lsb-release sudo g++ gcc flex \
bison make patch git
bison make patch git python3.7 python3.7-dev python3.7-distutils
update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.7 1
curl -s https://bootstrap.pypa.io/get-pip.py -o get-pip.py
python3 get-pip.py --force-reinstall
rm get-pip.py

- name: Checkout Kani
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion docs/src/install-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ GitHub CI workflows, see [GitHub CI Action](./install-github-ci.md).

The following must already be installed:

* **Python version 3.6 or newer** and the package installer `pip`.
* **Python version 3.7 or newer** and the package installer `pip`.
* Rust 1.58 or newer installed via `rustup`.
* `ctags` is required for Kani's `--visualize` option to work correctly. [Universal ctags](https://ctags.io/) is recommended.

Expand Down
14 changes: 12 additions & 2 deletions scripts/ci/Dockerfile.bundle-test-ubuntu-18-04
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,19 @@
FROM ubuntu:18.04
ENV DEBIAN_FRONTEND=noninteractive \
DEBCONF_NONINTERACTIVE_SEEN=true

RUN apt-get update && \
apt-get install -y python3 python3-pip curl ctags && \
curl -sSf https://sh.rustup.rs | sh -s -- -y
apt-get install --no-install-recommends -y build-essential software-properties-common && \
add-apt-repository -y ppa:deadsnakes/ppa && \
apt install --no-install-recommends -y python3.7 python3.7-dev python3.7-distutils curl ctags

RUN update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.7 1

RUN curl -s https://bootstrap.pypa.io/get-pip.py -o get-pip.py && \
python3 get-pip.py --force-reinstall && \
rm get-pip.py

RUN curl -sSf https://sh.rustup.rs | sh -s -- -y
ENV PATH="/root/.cargo/bin:${PATH}"

WORKDIR /tmp/kani
Expand Down