Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminated variable shadowing from test event listeners (runner.spec.js) #3712

Merged
merged 2 commits into from
Feb 4, 2019
Merged

Eliminated variable shadowing from test event listeners (runner.spec.js) #3712

merged 2 commits into from
Feb 4, 2019

Commits on Feb 4, 2019

  1. test(unit/runner.spec.js): Eliminated variable shadowing from event l… 

    …isteners

Made consistent that all listener function arguments were distinct from the variables being passed.
Added some additional assertions.
    @plroebuck
    plroebuck committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    548e261 View commit details
    Browse the repository at this point in the history

  2. test(unit/runner.spec.js): Fix two assertions 

    Ran test but didn't save first?
    @plroebuck
    plroebuck committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    ae2cd79 View commit details
    Browse the repository at this point in the history