add 'test verify' hook #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… after each test has run
|
What's the use-case |
|
Mocking / stubbing frameworks often have things like "make sure this function gets called". Obviously, they can't determine whether this has not happened until the test is complete. I originally put this sort of thing (a call to mockframework.verifyAll()) in an "after test" hook, but an exception thrown from there does not seem to fail the test properly. Also, that requires you to write mockframework.verifyAll() as an afterEach in at least every file, while ideally this would be something the framework hooks up for you (thus the runner hook). |
|
This issue has been inactive for over 1 month so I'm closing it. If you think it's still an issue re-open. - tjbot |
|
I still think it's an issue. Apparently I don't have permission to re-open this. Is that a bug, or am I really not allowed to reopen it? |
|
I like the idea of being able to fail the previous test within the afterEach hook, but if possible (should be) it would be nice to avoid the extra hook, even if it's just something lame like: afterEach(function(){
if (somethingFailed) this.test.fail(msg)
}) |
|
looks reasonable, I'll pull it down in a bit and have a look |
jjoos
added a commit
to jjoos/mocha
that referenced
this pull request
Oct 23, 2015
In version 1.2.1, support was added to fail test in the after each hook: > * Added `this.test.error(err)` support to after each hooks. Closes mochajs#287 While migrating from teaspoon-mocha to karma-mocha, we discovered that in the current mocha version this isn't supported anymore (or we don't understand how). In teaspoon this behaviour seems to be patched (running it with the exact same mocha.js 2.2.4 file, teaspoon and karma have different behaviour), although I couldn't quickly pinpoint the code that does that. This patch adds this behaviour back to the code base, but also seems to break certain behaviour (3 tests are failing with this pull request). But I don't understand what those test failures exactly mean. Also I found it quite difficult to add test coverage of this behaviour. Since there aren't any tests calling `runTests`. Help in figuring out what we've done wrong or how we could fix this pull request, would be appreciated. Not supporting this behaviour anymore due to added complexity in the code, would also be fine, but adding some documentation about dropping this functionality would be nice.
jjoos
added a commit
to jjoos/mocha
that referenced
this pull request
Mar 17, 2016
In version 1.2.1, support was added to fail test in the after each hook: > * Added `this.test.error(err)` support to after each hooks. Closes mochajs#287 While migrating from teaspoon-mocha to karma-mocha, we discovered that in the current mocha version this isn't supported anymore (or we don't understand how). In teaspoon this behaviour seems to be patched (running it with the exact same mocha.js 2.2.4 file, teaspoon and karma have different behaviour), although I couldn't quickly pinpoint the code that does that. This patch adds this behaviour back to the code base, but also seems to break certain behaviour (3 tests are failing with this pull request). But I don't understand what those test failures exactly mean. Also I found it quite difficult to add test coverage of this behaviour. Since there aren't any tests calling `runTests`. Help in figuring out what we've done wrong or how we could fix this pull request, would be appreciated. Not supporting this behaviour anymore due to added complexity in the code, would also be fine, but adding some documentation about dropping this functionality would be nice.
jjoos
added a commit
to jjoos/mocha
that referenced
this pull request
Mar 17, 2016
In version 1.2.1, support was added to fail test in the after each hook: > * Added `this.test.error(err)` support to after each hooks. Closes mochajs#287 While migrating from teaspoon-mocha to karma-mocha, we discovered that in the current mocha version this isn't supported anymore (or we don't understand how). In teaspoon this behaviour seems to be patched (running it with the exact same mocha.js 2.2.4 file, teaspoon and karma have different behaviour), although I couldn't quickly pinpoint the code that does that. This patch adds this behaviour back to the code base, but also seems to break certain behaviour (3 tests are failing with this pull request). But I don't understand what those test failures exactly mean. Also I found it quite difficult to add test coverage of this behaviour. Since there aren't any tests calling `runTests`. Help in figuring out what we've done wrong or how we could fix this pull request, would be appreciated. Not supporting this behaviour anymore due to added complexity in the code, would also be fine, but adding some documentation about dropping this functionality would be nice.
jjoos
added a commit
to jjoos/mocha
that referenced
this pull request
Mar 17, 2016
In version 1.2.1, support was added to fail test in the after each hook: > * Added `this.test.error(err)` support to after each hooks. Closes mochajs#287 While migrating from teaspoon-mocha to karma-mocha, we discovered that in the current mocha version this isn't supported anymore (or we don't understand how). In teaspoon this behaviour seems to be patched (running it with the exact same mocha.js 2.2.4 file, teaspoon and karma have different behaviour), although I couldn't quickly pinpoint the code that does that. This patch adds this behaviour back to the code base, but also seems to break certain behaviour (3 tests are failing with this pull request). But I don't understand what those test failures exactly mean. Also I found it quite difficult to add test coverage of this behaviour. Since there aren't any tests calling `runTests`. Help in figuring out what we've done wrong or how we could fix this pull request, would be appreciated. Not supporting this behaviour anymore due to added complexity in the code, would also be fine, but adding some documentation about dropping this functionality would be nice.
jjoos
added a commit
to jjoos/mocha
that referenced
this pull request
Mar 17, 2016
In version 1.2.1, support was added to fail test in the after each hook: >* Added `this.test.error(err)` support to after each hooks. Closes mochajs#287 While migrating from teaspoon-mocha to karma-mocha, we discovered that in the current mocha version this isn't supported anymore. That behaviour has been changed in: ebc6aee without any documentation change. If this was a conscious decision adding some documentation about dropping this functionality would then be nice. The old behaviour is documented in: https://github.com/mochajs/mocha/wiki/Conditionally-failing-tests-in-afterEach()-hooks .
jjoos
added a commit
to jjoos/mocha
that referenced
this pull request
Mar 17, 2016
In version 1.2.1, support was added to fail test in the after each hook: >* Added `this.test.error(err)` support to after each hooks. Closes mochajs#287 While migrating from teaspoon-mocha to karma-mocha, we discovered that in the current mocha version this isn't supported anymore. That behaviour has been changed in: ebc6aee without any documentation change. If this was a conscious decision adding some documentation about dropping this functionality would then be nice. The old behaviour is documented in: https://github.com/mochajs/mocha/wiki/Conditionally-failing-tests-in-afterEach()-hooks .
jjoos
added a commit
to jjoos/mocha
that referenced
this pull request
Mar 17, 2016
In version 1.2.1, support was added to fail test in the after each hook: >* Added `this.test.error(err)` support to after each hooks. Closes mochajs#287 While migrating from teaspoon-mocha to karma-mocha, we discovered that in the current mocha version this isn't supported anymore. That behaviour has been changed in: ebc6aee without any documentation change. If this was a conscious decision adding some documentation about dropping this functionality would then be nice. The old behaviour is documented in: https://github.com/mochajs/mocha/wiki/Conditionally-failing-tests-in-afterEach()-hooks .
jjoos
added a commit
to jjoos/mocha
that referenced
this pull request
Mar 23, 2016
In version 1.2.1, support was added to fail test in the after each hook: >* Added `this.test.error(err)` support to after each hooks. Closes mochajs#287 While migrating from teaspoon-mocha to karma-mocha, we discovered that in the current mocha version this isn't supported anymore. That behaviour has been changed in: ebc6aee without any documentation change. If this was a conscious decision adding some documentation about dropping this functionality would then be nice. The old behaviour is documented in: https://github.com/mochajs/mocha/wiki/Conditionally-failing-tests-in-afterEach()-hooks .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for use by frameworks to always perform verification / teardown after a test has run (but before it is declared successful or failed).