Added SimpleDiff #733
Closed
Added SimpleDiff #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, this would really really help me as well. I love the way it is for integration tests but some times it can really slow me down. I find myself console.log'ing to see what the entire line was... For my particular use I find that 75 chars is a nice breakpoint. @bitmage thanks for the pull request! At the very least i'm using it on my local copy of Mocha. |
|
Maybe just show the diff and show the actual/expected, such as qUnit does? The diffs can occasionally be baffling in any use case--objects, numbers, strings--and sometimes extremely useful; it's hard to predict in some logical way. |
|
yeah tough call sometimes it's handy, configurable would be nice |
wvl
added a commit
to wvl/mocha
that referenced
this pull request
May 29, 2013
* upstream/master: (63 commits) mkdirp dep - latest version add object diff test style Release 1.10.0 remove anon-wrapper in tail.js now that the entire thing is wrapped refactor use resolve() instead of join() for --require change to always use word-based diffs for now. Closes mochajs#733 add support to pass through flags such as --debug-brk=1234. Closes mochajs#852 remove a comment Add globbing to support windows-style globs. Adding filterLeaks() condition to not consider indices in global object as leaks fix mocha.css whitespace Restricting css rules to the mocha container as necessary. Should minimize interference with external styles add sans-serif for arial fallback fix weird "em" whitespace Save timer references to avoid Sinon interfering in the browser build. prevent hooks from being called if we are bailing adding before hook to --bail test Support `--prof` for profiling ... Conflicts: mocha.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often have instances where the diff printout obstructs the problem rather than clarifying it. For instance:
With the change I made, it now avoids the work of interspersing the actual/expected:
I suppose I don't expect this to be accepted vanilla, but maybe we could have something which detects how many characters (or characters in a row) are different. If there's a big difference (easy to see, likely completely different strings), just show them side by side with simpleDiff. If there's a small difference (hard to see, probably a similar string), then use your existing diff.
Related to this, it seems like the showDiff flag is being ignored. I'm using should.js, and upon removing the showDiff flag there, mocha still displayed the exact same output. Is that intentional?
It sure would be nice to have a config option for diff formatting!