Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer all mocha flags over node flags; closes #4417 #4418

Merged
merged 1 commit into from
Aug 25, 2020
Merged

prefer all mocha flags over node flags; closes #4417 #4418

merged 1 commit into from
Aug 25, 2020

Conversation

boneskull
Copy link
Contributor

  • no more require special-case
  • future-proofs mocha against the introduction of conflicting flags in node

Fixes #4417
Ref: nodejs/node#34852

@boneskull
prefer all mocha flags over node flags; closes #4417
213e0c0 
- no more `require` special-case
- future-proofs `mocha` against the introduction of conflicting flags in `node`
@boneskull boneskull added type: bug a defect, confirmed by a maintainer semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Aug 25, 2020
@boneskull boneskull self-assigned this Aug 25, 2020
@boneskull boneskull mentioned this pull request Aug 25, 2020
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.809% when pulling 213e0c0 on boneskull/issue/4417 into 4d7a171 on master.

@boneskull boneskull merged commit aeec37a into master Aug 25, 2020
@boneskull boneskull deleted the boneskull/issue/4417 branch August 25, 2020 19:09
@boneskull boneskull added this to the next milestone Aug 25, 2020
@Omrisnyk Omrisnyk mentioned this pull request Dec 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@boneskull boneskull

Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes" type: bug a defect, confirmed by a maintainer
Projects
None yet
Milestone
v8.1.2
Development

Successfully merging this pull request may close these issues.

node flag parsing strategy is backwards
2 participants
@boneskull @coveralls